Skip to content

Move SSH key copy button to the left#1888

Draft
KCarretto wants to merge 2 commits intomainfrom
import-repo-copy-btn-9313496041808805669
Draft

Move SSH key copy button to the left#1888
KCarretto wants to merge 2 commits intomainfrom
import-repo-copy-btn-9313496041808805669

Conversation

@KCarretto
Copy link
Copy Markdown
Collaborator

Moved the copy button for the SSH key in the "Import Repository" modal to the left of the key and made it slightly bigger.

  • Modified tavern/internal/www/src/pages/tomes/import-modal/StepAddDeploymentKey.tsx to use a custom layout for the copy button.
  • Verified the changes with a Playwright script and attached a screenshot.

PR created automatically by Jules for task 9313496041808805669 started by @KCarretto

Modified `StepAddDeploymentKey.tsx` to move the copy button to the left of the SSH key code block and increased its size slightly for better visibility and usability. Implemented custom copy logic using `navigator.clipboard` and replaced the internal `CodeBlock` copy button with a standalone `Button` component.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2662    ±0 2662    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1242 2662 2662 0 0 0 0 45.7s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2662 0 0 10.3s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_SimpleEcho 1 10.3s 10.3s
TestDockerExecutor_Build_StderrOutput 1 9.7s 9.7s
TestDockerExecutor_Build_MultiLineOutput 1 7.5s 7.5s
TestDockerExecutor_Build_ContextCancellation 1 5.9s 5.9s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s
imix::bin/imix: install::tests::test_install_execution 3 1.5s 4.5s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

<div className="flex flex-col gap-2">
<Heading size="sm">Copy public key</Heading>
<CodeBlock code={newRepository?.publicKey || ""} showCopyButton />
<div className="flex flex-row items-start gap-2">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a copy button in CodeBlock. We should probably be editing and modifying that rather than creating a wrapper with duplicated functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants