Add Clipboard Button, Ensure Credentials Keeps Newlines#1883
Open
Add Clipboard Button, Ensure Credentials Keeps Newlines#1883
Conversation
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
cmp5987
reviewed
Feb 26, 2026
| </Button> | ||
| </> | ||
| <div className="flex flex-row items-center gap-2"> | ||
| <p className="flex-1" style={{ whiteSpace: 'pre-line' }}> |
Collaborator
There was a problem hiding this comment.
Nit: Swap to tailwind version of this rather than mixing styles
Collaborator
There was a problem hiding this comment.
cmp5987
approved these changes
Feb 26, 2026
| accessorFn: row => row.principal, | ||
| footer: props => props.column.id, | ||
| maxSize: 100, | ||
| maxSize: 10, |
Collaborator
There was a problem hiding this comment.
Ah is this working as you intend, this seems very small for a maxSize.
| accessorFn: row => row.secret, | ||
| footer: props => props.column.id, | ||
| maxSize: 250, | ||
| // maxSize: 250, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes UI such that:
Which issue(s) this PR fixes:
Fixes #1818