[966] simplify partner logo system and add partnership label#247
[966] simplify partner logo system and add partnership label#247IhorMasechko merged 2 commits intomainfrom
Conversation
- Replace separate mobile/desktop logo fields with single responsive logo - Add partner name field and display 'In partnership with' label - Make partnership section clickable when partner website is available - Update logo styling to use responsive max dimensions instead of fixed sizes - Change partner sorting to alphabetical by title Co-authored-by: Cursor <cursoragent@cursor.com>
WalkthroughThis pull request consolidates mobile and desktop partnership logo handling into a single responsive logo field across multiple modules. The business-partner module adds a new Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Vulnerabilities of
|
| digest | sha256:47b952f9ed1f4131c73dc91a050dceae36c06ea9d57862f434527bc1d0cf3cef |
| vulnerabilities | |
| platform | linux/amd64 |
| size | 172 MB |
| packages | 977 |
📦 Base Image node:24-alpine
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
website/modules/business-partner/index.js (1)
19-30:⚠️ Potential issue | 🟠 MajorAdd a database migration before deploying this schema change.
Renaming
partnerLogoDesktop→partnerLogoand removingpartnerLogoMobileis a schema change that requires a migration script. Existing business-partner documents in the database will still have data under the old field names, making them invisible to the newpartnerLogofield. This will silently cause all partner logos to disappear from the site for existing partners.Create a migration to copy the existing
partnerLogoDesktopdata intopartnerLogofor all business-partner documents before this deploy, or confirm that no existing data exists for these fields.
🤖 Fix all issues with AI agents
In `@website/modules/asset/ui/src/scss/_cases.scss`:
- Around line 1440-1448: The mobile font size for .cs_partnership-text is set to
6px via the font-settings call (default scope) which is unreadable; either
increase the default mobile size to a readable minimum (e.g., change
font-settings(6px, ...) to font-settings(12px, ...) for the default rule) or, if
constrained by the 66px box, hide the label on small screens instead (add a
small-screen rule that sets display:none or visibility:hidden for
.cs_partnership-text). Keep the existing `@include` breakpoint-medium {
font-settings(14px, ...) } for larger screens.
refactor: simplify partner logo system and add partnership label
Replace separate mobile/desktop logo fields with single responsive logo
Add partner name field and display 'In partnership with' label
Make partnership section clickable when partner website is available
Update logo styling to use responsive max dimensions instead of fixed sizes
Change partner sorting to alphabetical by title
Refactored the partner logo system to use a single responsive logo field instead of separate mobile and desktop variants. Added a partner name field and implemented an "In partnership with" label display. Updated logo styling with responsive max dimensions and changed partner sorting from creation date to alphabetical title order.