Skip to content

[596] fix: Breadcrumb margins and rendering issues #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitalyyP merged 8 commits into from
May 21, 2025
Merged

[596] fix: Breadcrumb margins and rendering issues #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e2c8ec1
style/update-breadcrumb-and-header
VitalyyP May 20, 2025
e040547
Fix breadcrumb margins and rendering position
VitalyyP May 20, 2025
f0d6124
fix
VitalyyP May 20, 2025
648b90d
Merge branch 'main' into 596-fix/breadcrumb-margins-and-render-issue
VitalyyP May 20, 2025
75a7622
Merge branch 'main' into 596-fix/breadcrumb-margins-and-render-issue
VitalyyP May 21, 2025
972d174
Merge branch 'main' into 596-fix/breadcrumb-margins-and-render-issue
VitalyyP May 21, 2025
eb84c57
remove margin-top from main
VitalyyP May 21, 2025
a6f0cf3
remove margin-left
VitalyyP May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions website/modules/asset/ui/src/scss/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,10 @@
font-size: $font-size-body-small-mobile;
line-height: 150%;
width: min(1280px, 100%);
padding: 64px 0 52px 40px;
margin: 0 auto;
padding: 0 40px;
height: 100%;
color: $black;
@include breakpoint-medium {
padding: 95px 0 80px 40px;
}
}

.breadcrumb-list {
Expand Down
6 changes: 2 additions & 4 deletions website/modules/asset/ui/src/scss/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
}

.sf-logo {
font-size: 12px;
font-weight: 800;
z-index: 11;
text-transform: uppercase;
color: $gray-500;
Expand All @@ -31,9 +29,9 @@
&:focus {
color: $gray-300;
}
@include font-settings(16px, 110%, 700);
@include breakpoint-medium {
font-size: $font-size-body-small;
line-height: $line-height-h1;
@include font-settings(14px, 110%, 800);
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions website/views/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
data-barba="wrapper"
data-barba-namespace="home"
>
{% render fragments.header() %} {% render fragments.breadcrumbs() %}
{% render fragments.header() %}
<main
class="bp-main"
role="main"
Expand All @@ -24,7 +24,8 @@
endif
%}
>
<div class="sf-container">
{% render fragments.breadcrumbs() %}
<div class="sf-container" style="padding-top: 20px">
{% endblock %} {% block main %} {# Usually, your page templates in the
@apostrophecms/pages module will override this block. It is safe to assume
this is where your page-specific content should go. #} {% endblock %} {%
Expand Down
Loading