Skip to content

Conversation

@AmitSahastra
Copy link
Contributor

@AmitSahastra AmitSahastra commented Nov 12, 2025

Replaced systemctl commands with snap commands for LXD service management and diagnostics

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a crash loop issue with lxd-initializer pods in EC Vertex environments by migrating from systemd-based LXD service management to snap-based commands, ensuring proper host-level execution.

  • Replaced systemctl commands with snap commands for LXD service management and diagnostics
  • Updated init container to check and install LXD on the host rather than in the container
  • Enhanced logging throughout the DaemonSet reconciliation process
  • Improved DaemonSet update logic to properly handle spec changes during reconciliation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
lxd-initializer/lxd-initializer.go Replaced systemctl commands with snap equivalents for LXD service management and diagnostics
controllers/templates/lxd_initializer_ds.yaml Modified init container to install and start LXD on host using nsenter, updated image tag
controllers/lxd_initializer_ds.go Added comprehensive error logging and improved DaemonSet CreateOrPatch logic to properly handle updates
Makefile Updated SPECTRO_VERSION to reflect current development version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AmitSahastra AmitSahastra merged commit 2042ed7 into spectro-master Nov 12, 2025
4 checks passed
@AmitSahastra AmitSahastra deleted the PCP-5506 branch November 12, 2025 11:40
github-actions bot pushed a commit that referenced this pull request Nov 12, 2025
…are in Init:CrashLoopBackOff state (#291)

(cherry picked from commit 2042ed7)
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
spectro-release-4.8

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

AmitSahastra added a commit that referenced this pull request Nov 12, 2025
…are in Init:CrashLoopBackOff state (#291) (#292)

(cherry picked from commit 2042ed7)

Co-authored-by: Amit Sahastrabuddhe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants