Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace period. Code cleanup.
AmitSahastra
changed the title
![bulwark-spectrocloud[bot]](https://avatars.githubusercontent.com/u/36211249?s=60&v=4){kind=small}
There was a problem hiding this comment.
- G115: integer overflow conversion int64 -> int32, Severity: HIGH
-
- File: /home/runner/_work/bulwark/bulwark/target-repo/controllers/lxd_initializer_ds.go:121:24
-
- File: /home/runner/_work/bulwark/bulwark/target-repo/controllers/lxd_initializer_ds.go:118:23
-
- File: /home/runner/_work/bulwark/bulwark/target-repo/controllers/lxd_initializer_ds.go:102:23
-
- File: /home/runner/_work/bulwark/bulwark/target-repo/controllers/lxd_initializer_ds.go:142:11
-
- File: /home/runner/_work/bulwark/bulwark/target-repo/controllers/lxd_initializer_ds.go:142:53
-
- G404: Use of weak random number generator (math/rand or math/rand/v2 instead of crypto/rand), Severity: HIGH
-
- File: /home/runner/_work/bulwark/bulwark/target-repo/lxd-initializer/lxd-initializer.go:636:22
-
Please review these findings and fix the issues before merging.
jayesh-srivastava
approved these changes
Sep 16, 2025
AmitSahastra
dismissed
bulwark-spectrocloud[bot]’s stale review
Will fix in next pr
AmitSahastra
added a commit
that referenced
this pull request
Sep 17, 2025
* PCP-5152: Multiple node HCP cluster losing interface reference * Additional changes (#225) * Additional changes * trust password and code cleanup (#226) * Additional changes * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. (#234) * Additional changes * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. * - Gosec fix - Cleanup daemonset once all host are registered * Additional changes * Use hsotname for lxd registration. Code refactoring. (#240) * Use hsotname for lxd registration. Code refactoring. * merge conflict
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
* PCP-5152: Multiple node HCP cluster losing interface reference * Additional changes (#225) * Additional changes * trust password and code cleanup (#226) * Additional changes * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. (#234) * Additional changes * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. * - Gosec fix - Cleanup daemonset once all host are registered * Additional changes * Use hsotname for lxd registration. Code refactoring. (#240) * Use hsotname for lxd registration. Code refactoring. * merge conflict (cherry picked from commit 5939162)
AmitSahastra
added a commit
that referenced
this pull request
Sep 17, 2025
…#244) * PCP-5152: Multiple node HCP cluster losing interface reference * Additional changes (#225) * Additional changes * trust password and code cleanup (#226) * Additional changes * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. (#234) * Additional changes * Add gate to registration logic, seperate it to initializer and put grace period. Code cleanup. * - Gosec fix - Cleanup daemonset once all host are registered * Additional changes * Use hsotname for lxd registration. Code refactoring. (#240) * Use hsotname for lxd registration. Code refactoring. * merge conflict (cherry picked from commit 5939162) Co-authored-by: Amit Sahastrabuddhe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.