error handling

AmitSahastra · AmitSahastra · commit 0c31d5f67ae7 · 2025-09-13T15:53:10.000+05:30
diff --git a/controllers/maasmachine_controller.go b/controllers/maasmachine_controller.go
@@ -242,7 +242,6 @@ func (r *MaasMachineReconciler) reconcileDelete(_ context.Context, machineScope
 									}
 									// Fetch details to confirm and delete
 									if gm, ge := client.Machines().Machine(gid).Get(ctx); ge == nil {
-										_ = client.Machines().Machine(gm.SystemID()).Delete(ctx)
 										if derr := client.Machines().Machine(gm.SystemID()).Delete(ctx); derr != nil {
 											machineScope.Error(derr, "failed to delete guest VM during host release cleanup", "guestSystemID", gm.SystemID())
 										}

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,6 @@ func (r *MaasMachineReconciler) reconcileDelete(_ context.Context, machineScope`
`242`	`242`	`}`
`243`	`243`	`// Fetch details to confirm and delete`
`244`	`244`	`if gm, ge := client.Machines().Machine(gid).Get(ctx); ge == nil {`
`245`		`- _ = client.Machines().Machine(gm.SystemID()).Delete(ctx)`
`246`	`245`	`if derr := client.Machines().Machine(gm.SystemID()).Delete(ctx); derr != nil {`
`247`	`246`	`machineScope.Error(derr, "failed to delete guest VM during host release cleanup", "guestSystemID", gm.SystemID())`
`248`	`247`	`}`