error handling (#229)

AmitSahastra · web-flow · commit 9b529c0375e6 · 2025-09-13T15:37:54.000+05:30
diff --git a/controllers/maasmachine_controller.go b/controllers/maasmachine_controller.go
@@ -243,6 +243,9 @@ func (r *MaasMachineReconciler) reconcileDelete(_ context.Context, machineScope
 									// Fetch details to confirm and delete
 									if gm, ge := client.Machines().Machine(gid).Get(ctx); ge == nil {
 										_ = client.Machines().Machine(gm.SystemID()).Delete(ctx)
+										if derr := client.Machines().Machine(gm.SystemID()).Delete(ctx); derr != nil {
+											machineScope.Error(derr, "failed to delete guest VM during host release cleanup", "guestSystemID", gm.SystemID())
+										}
 									}
 								}
 							}

Original file line number	Diff line number	Diff line change
`@@ -243,6 +243,9 @@ func (r *MaasMachineReconciler) reconcileDelete(_ context.Context, machineScope`
`243`	`243`	`// Fetch details to confirm and delete`
`244`	`244`	`if gm, ge := client.Machines().Machine(gid).Get(ctx); ge == nil {`
`245`	`245`	`_ = client.Machines().Machine(gm.SystemID()).Delete(ctx)`
	`246`	`+ if derr := client.Machines().Machine(gm.SystemID()).Delete(ctx); derr != nil {`
	`247`	`+ machineScope.Error(derr, "failed to delete guest VM during host release cleanup", "guestSystemID", gm.SystemID())`
	`248`	`+ }`
`246`	`249`	`}`
`247`	`250`	`}`
`248`	`251`	`}`