Skip to content

chore(docker compose): pin docker-compose-speckle example#4829

Open
iainsproat wants to merge 1 commit into
mainfrom
iain/fix-docker-compose-speckle
Open

chore(docker compose): pin docker-compose-speckle example#4829
iainsproat wants to merge 1 commit into
mainfrom
iain/fix-docker-compose-speckle

Conversation

@iainsproat

Copy link
Copy Markdown
Contributor

Description & motivation

Our example docker-compose-speckle.yml file was using a local tag for images. This local tag does not exist in the remote repository, which causes docker compose to fallback to the build instructions within the docker compose file.

We wish for the docker compose file to default to running stable builds, and only build new images where explicitly requested.

Changes:

  • docker compose --file docker-compose-speckle.yml up --detach will now pull the last released 2.*.* version of the images from the remote repository.
  • To build and deploy images from local changes, run docker compose --file docker-compose-speckle.yml up --detach --build

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

- pin to released major version '2'
- To build images, need to use '--build' flag
@iainsproat iainsproat marked this pull request as ready for review May 27, 2025 13:57
@codecov

codecov Bot commented Aug 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.35%. Comparing base (131b964) to head (83dddf4).
⚠️ Report is 1006 commits behind head on main.

❌ Your project check has failed because the head coverage (70.35%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4829   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files         579      579           
  Lines       25032    25032           
  Branches     3733     3733           
=======================================
  Hits        17611    17611           
  Misses       6253     6253           
  Partials     1168     1168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant