Replace hardcoded Assert URL with data-cite mechanism #5090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Moved algorithms.js to run before inlines.js in all profiles - Updated algorithms.js to use data-cite="INFRA#assert" for linking - Updated tests to include localBiblio for INFRA spec Co-authored-by: marcoscaceres <[email protected]>
Contributor
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
@copilot, exclude the builds/ in the commit. No need for those.
src/core/algorithms.js
Outdated
| html`<a href="https://infra.spec.whatwg.org/#assert">Assert</a>`, | ||
| ": " | ||
| ); | ||
| li.prepend(html`<a data-cite="INFRA#assert">Assert</a>`, ": "); |
Contributor
There was a problem hiding this comment.
@copilot not quite. Just do and let ReSpec do the linking:
Suggested change
| li.prepend(html`<a data-cite="INFRA#assert">Assert</a>`, ": "); | |
| li.prepend(html`[=Assert=]:`); |
Author
There was a problem hiding this comment.
Done in commit 0be2a94. Changed to use [=Assert=]: and added logic to add data-cite="INFRA" to the <li> element if infra is not already cited in the ancestor tree.
tests/spec/core/algorithms-spec.js
Outdated
| describe("Core — Algorithm Lists", () => { | ||
| afterAll(flushIframes); | ||
|
|
||
| const localBiblio = { |
Contributor
There was a problem hiding this comment.
@copilot, no need to add this... the reference to infra needs to be added automatically.
What should happen is that you need to check if anything in the tree is already citing "infra", and if not, add data-cite="infra" to the closest parent node (i.e., the closest <li>)
Suggested change
| const localBiblio = { | |
| const localBiblio = { |
Author
There was a problem hiding this comment.
Reverted the localBiblio changes and implemented the logic to check if data-cite="infra" already exists in the tree. If not, it gets added to the <li> element (commit 0be2a94).
marcoscaceres
requested changes
Nov 26, 2025
Contributor
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
@copilot some suggestions for you.
Copilot
AI
changed the title
[WIP] Fix hard coded Assert URL in algorithm.js
Replace hardcoded Assert URL with data-cite mechanism
Nov 26, 2025
Copilot finished work on behalf of
marcoscaceres
November 26, 2025 01:34
- Replace explicit anchor with [=Assert=] syntax for ReSpec linking - Add data-cite="INFRA" to li element if not already citing infra - Revert test file and builds folder to original state Co-authored-by: marcoscaceres <[email protected]>
Author
Excluded builds/ from the commit by reverting them to the original state (commit 0be2a94). Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
marcoscaceres
November 26, 2025 02:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[=Assert=]:syntaxdata-cite="INFRA"to li element if infra not already cited in treeOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.