Skip to content

Move quick return to top of method isStandardLicenseExceptionWithinText #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

Move quick return to top of method isStandardLicenseExceptionWithinText #336

merged 2 commits into from
Jun 2, 2025

Conversation

bact
Copy link
Collaborator

@bact bact commented May 21, 2025

Reduce one assignment in case one of the inputs is null.

goneall
goneall approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I don't think this will have much impact on performance, but it does make it a bit more logical to read

@goneall goneall merged commit dc1235a into spdx:master Jun 2, 2025
1 check passed
@bact bact deleted the refactor-quick-return branch June 2, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bact @goneall