Add RawQuery #73
Open
Add RawQuery #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what @freekmurze thinks, but in my humble opinion I think I'd rather people create Query implementations in their own codebase, rather than promote raw arrays. If their Query classes are generic enough, I'll gladly accept them into this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
RawQuery, which can be used as a catch-all for any raw query that you want to add to the builder. It accepts an array, which will be added to the query body as-is. This can be used for anything that, at this point in time, is not supported by this package yet.Feel free to reject this PR as it might go against the idea of creating structured classes for all queries.