Skip fnmatch for URLs longer than FILENAME_MAX#505
Merged
Conversation
fnmatch() raises a warning when the haystack exceeds the platform's FILENAME_MAX (4096 on Linux, 1024 on macOS/BSD), which under Laravel's error handler bubbles up as an ErrorException and kills the crawl job. Guard matchesAlwaysCrawl()/matchesNeverCrawl() with a length check so overly-long discovered URLs short-circuit to false and fall through to the normal CrawlProfile check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fnmatch()raises a warning when the haystack exceeds the platform'sFILENAME_MAX(4096 on Linux, 1024 on macOS/BSD). Under a framework like Laravel that converts warnings toErrorExceptionthis kills the crawl job withfnmatch(): Filename exceeds the maximum allowed length of 4096 characterswhenever a discovered URL is unusually long andalwaysCrawl()orneverCrawl()patterns are set.Guard
matchesAlwaysCrawl()/matchesNeverCrawl()with a length check (1024, the lowest commonFILENAME_MAXacross supported platforms) so overly-long URLs short-circuit tofalseand fall through to the normalCrawlProfile::shouldCrawl()check downstream. Real URLs almost never exceed this, and a URL too long to glob can't meaningfully match a pattern anyway.Two regression tests added in
AlwaysNeverCrawlTest.phpcover both methods.