theme comparison tool: use "git worktree" to build themes#387
Conversation
|
Just tried it and it works nicely 😄 But I found 2 Problems:
if not WORKTREE_DIR.exists():
if str(WORKTREE_DIR).replace("\\", "/") in repo.git.worktree("list"):
repo.git.worktree("remove", WORKTREE_DIR)
repo.git.worktree("add", WORKTREE_DIR, "--detach")
|
|
Thanks for trying this out! ad 1: I've also seen this problem in the meantime. Your solution should work fine, but probably we could use as_posix() to avoid the manual replace? ad 2: I know. As mentioned in #379 (comment), Anyway, I just wanted to see here if what I suggested in #379 would actually work and how much code it would need. Obviously this is much shorter than #379, but of course there are several features missing here. Do you want to try to make your solution in #379 shorter (or at least simpler) or probably use a few things from here over there? |
|
Using I will refactor #379 and use some of your code. |
7bb1e17 to
e5d440c
Compare
c32a5b9 to
ae917e6
Compare
ae917e6 to
4470e4a
Compare
|
I've squashed the commits and made this ready for review. @s-weigand I've tried to keep your authorship for the documentation. I think it works really well, except the |
This is not meant to be merged!
This is just a proof of concept, to be able to actually try if the "git worktree" approach could work.
Of course a lot of error checking, comments and other details are missing.
The goal was to implement the essential functionality with as little code as possible.
The version in #379 has many more features, but I just wanted to try the basic stuff.