SpackCIBridge: don't post status when required label is missing#1376
Merged
Conversation
Prior to this commit, the sync script would post a pending status to PRs on GitHub that are missing the project-specific label that's required for GitLab CI testing to start. Uers found this confusing because it makes it appear as if CI has not finished running yet. Instead we now opt not to post any status at all in this situation A skipped status would be better, but that is only supported from "checks" (GitHub Actions), not "statuses".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the sync script would post a pending status to PRs on GitHub that are missing the project-specific label that's required for GitLab CI testing to start.
Users found this confusing because it makes it appear as if CI has not finished running yet. Instead we now opt not to post any status at all in this situation A skipped status would be better, but that is only supported from "checks" (GitHub Actions), not "statuses".