Fix #501: Remove broken logo from README#549
Open
karlhillx wants to merge 1 commit into
Open
Conversation
The relative-path img tag renders fine on GitHub but breaks on PyPI. Removing the logo since the image host is not accessible from PyPI.
github-actions
Bot
added
the
documentation
Collaborator
|
I'm hesitant to say that removing the brandmark entirely is the best solution here |
Author
|
Fair enough. I can switch the image src to an absolute raw URL so the brandmark renders on PyPI too: Want me to pin to a commit SHA instead of main so old releases don't break retroactively? Either way, I can update the PR. |
Collaborator
|
if we're going to point to a URL anyway then perhaps we should point to a central location in general PyPI readme rendering is important so I'll bring it up with our upcoming templating work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relative-path img tag renders on GitHub but breaks on PyPI. Removed.