Skip to content

Fix: Windows user directories incorrectly flagged as high risk paths #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nebhay wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix: Windows user directories incorrectly flagged as high risk paths #3019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/ops/locations/validate/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ impl LibraryQuery for ValidateLocationPathQuery {
let is_system_dir = system_dirs.iter().any(|d| {
// Special case: "/" should only match if path IS "/", not if it starts with "/"
// Otherwise every absolute path would be considered a system directory
let matches = if d.to_string_lossy() == "/" {
// Same for Windows drive roots like "C:\" - only match if path IS the drive root
let d_str = d.to_string_lossy();
let matches = if d_str == "/" || (cfg!(target_os = "windows") && d_str.ends_with(":\\")) {
path == d
} else {
path.starts_with(d)
Expand Down