bench: add bn254 scalar filed to the sumcheck benchmark #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the sumcheck benchmark to support multiple scalar fields, specifically adding bn254 alongside the existing curve25519 field. The changes enable field-agnostic benchmarking by introducing template-based implementations and command-line field selection.
- Templated the benchmark functions to work with different field types
- Added bn254 scalar field support with appropriate includes and dependencies
- Enhanced command-line interface to accept field selection as a parameter
- Improved benchmark output with statistical metrics including standard deviation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| benchmark/sumcheck/benchmark.m.cc | Refactored to support multiple scalar fields, templated functions, and enhanced statistical output |
| benchmark/sumcheck/BUILD | Added bn254 field dependencies for compilation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jacobtrombetta
force-pushed
the
bench/add-bn254-scalar-filed-to-sumcheck-benchmark
branch
from
bb9bcc8 to
f2a3af1
Compare
jacobtrombetta
force-pushed
the
bench/add-bn254-scalar-filed-to-sumcheck-benchmark
branch
from
f2a3af1 to
f001c6c
Compare
jacobtrombetta
force-pushed
the
bench/add-bn254-scalar-filed-to-sumcheck-benchmark
branch
from
f001c6c to
22b64cd
Compare
|
This PR has been marked as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The sumcheck benchmark currently only measures the Curve25519 field. The sumcheck benchmark is updated to support multiple fields. Additionally, the bn254 scalar field is added to the sumcheck benchmark.
What changes are included in this PR?
Are these changes tested?
Yes