Skip to content

Conversation

@CursedRock17
Copy link

This pull request doesn't solve any particular issue, but it does address all but two of the sections in the documentation which had been marked as TODO, so hopefully this allows the project to be more approachable. Those two sections were backports with rcutils and the Eventing and Telemetry System both of which have not been implemented.

@Bckempa Bckempa self-requested a review September 19, 2024 09:12
@ivanperez-keera
Copy link
Contributor

Hi @CursedRock17 . Thanks again for submitting this PR to the project.

Issue #34 and the associated PR #37 have now been merged. This issue addresses some of the same concerns. I'd like to revisit this PR now. Specifically, I'd like to rebase this PR on top of the current rolling, which incorporates the changes in #37, keeping what remains from this PR that would be an improvement wrt. to the current head.

@EzraBrooks
Copy link
Member

@mkhansenbot, Brian says to ping you here to make sure this documentation is still correct with new migrated demo locations

@ivanperez-keera
Copy link
Contributor

ivanperez-keera commented Nov 13, 2025

Hi @mkhansenbot . Do you have time to review this for the next release? It's ready for review.

We need to see if this rebases on top of our current HEAD (it won't cleanly), and adjust things accordingly based on what was already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants