Skip to content

ci: sync shared workflow callers - #85

Open
damacus wants to merge 1 commit into
mainfrom
codex/ci-sync-workflows
Open

ci: sync shared workflow callers#85
damacus wants to merge 1 commit into
mainfrom
codex/ci-sync-workflows

Conversation

@damacus

@damacus damacus commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Use the current shared Conventional Commit caller contract.
  • Pass the Slack secrets required by release workflow 9.0.0.
  • Restore workflow startup before the next merge to main.

Verification

  • actionlint on both changed workflows
  • yamllint on both changed workflows
  • git diff --check

@damacus
damacus requested a review from a team as a code owner August 17, 2026 07:24
@github-actions

Copy link
Copy Markdown

Slowest examples

Top 3 slowest examples (0.07 seconds, 100% of total time)
Example Description Time in seconds
spec/resources/install_spec.rb:12 chruby_install install chruby 0.03301
spec/resources/install_spec.rb:13 chruby_install install chruby 0.02182
spec/resources/install_spec.rb:23 chruby_install on Amazon Linux 0.01848

@damacus

damacus commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Note for future self

changes to the "conventional-commits" workflow:

  1. Keep the "synchronize" trigger. We want this validation to rerun whenever new commits are pushed or the PR head is otherwise updated. The trigger should remain:

    types: [opened, edited, reopened, synchronize]

  2. Review "secrets: inherit". This workflow appears to require only "pull-requests: read". If the reusable "sous-chefs/.github/.github/workflows/conventional-commits.yml@9.0.0" workflow does not explicitly require secrets, remove "secrets: inherit". We should avoid exposing repository secrets to a "pull_request_target" workflow unnecessarily.

Keep the switch to "pull_request_target"; this is PR-metadata validation and needs to work reliably for fork PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant