Skip to content

Conversation

@bluemmb
Copy link

@bluemmb bluemmb commented Sep 3, 2024

Description

Ubuntu is also using ntpsec from verson 23.10 onward.
This PR is a proposal to get aligned with this change.
https://packages.ubuntu.com/mantic/ntp
https://wiki.ubuntu.com/JonathanFerguson/NTP

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

Sorry don't know how to fix the test problem, no platform above the 22.04 listed here: https://github.com/chef/fauxhai/blob/main/PLATFORMS.md

Also will add the docs and changelogs if the changes are ok from your side

@bluemmb bluemmb requested a review from a team as a code owner September 3, 2024 13:08
@Stromweld Stromweld added the Release: Patch Release to Chef Supermarket as a version patch when merged label Sep 3, 2024
@Stromweld
Copy link
Contributor

try updating you spec to use ubuntu 24.04 and that should fix the platform version error.

@bluemmb
Copy link
Author

bluemmb commented Sep 4, 2024

@Stromweld Fixed tests as you mentioned, also added to changelog

@Stromweld
Copy link
Contributor

can you look into the failing integration checks

@p8
Copy link

p8 commented Oct 16, 2024

I also had to add /etc/ntpsec/** r, to files/usr.sbin.ntpd.apparmor.

@bluemmb
Copy link
Author

bluemmb commented Oct 16, 2024

@p8 you think it will solve those integration tests problems?

@p8
Copy link

p8 commented Oct 17, 2024

@bluemmb I think so. For example the following line complaining about apparmor:
https://github.com/sous-chefs/ntp/actions/runs/10698190152/job/29673154992?pr=254#step:4:289

Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a conditional depending on the platform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release: Patch Release to Chef Supermarket as a version patch when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants