This repository was archived by the owner on Sep 30, 2024. It is now read-only.
remove deprecated ConfigurationCascade GraphQL field #63935
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the last ~5 years, `viewerSettings`, `settingsCascade`, and `SettingsCascade` has been preferred over `viewerConfiguration`, `configurationCascade`, and `ConfigurationCascade`. There are no usages of the old API in our own code: https://sourcegraph.sourcegraph.com/search?q=context:sourcegraph+configurationcascade&patternType=literal. Therefore, I'm calling it safe to remove.
eseliger
reviewed
Jul 19, 2024
Comment on lines
+179
to
+180
| viewerSettings { | ||
| ...SettingsCascadeFields |
Member
There was a problem hiding this comment.
you said in the description
There are no usages of the old API in our own code
But this feels like a usage site?
The browser extension probably needs to be released (manual process I believe, not continuous) for this to go out, otherwise it will probably be broken? 🤔
Member
Author
There was a problem hiding this comment.
Ah yeah, you are right. Thank you for catching this. Confirmed the browser extension hits the viewerConfiguration API.
I'll release a new bext build first before merging this.
sqs
referenced
this pull request
Jul 19, 2024
…erConfiguration API (#63949) This API is deprecated (see https://github.com/sourcegraph/sourcegraph/pull/63935). The browser extension is still using it, and we need this PR to remove its usage, and then we need to publish it. Then we can pick up https://github.com/sourcegraph/sourcegraph/pull/63935 again. ## Test plan Confirm that the browser extension uses the new GraphQL query (in the background page network devtools tab).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the last ~5 years,
viewerSettings,settingsCascade, andSettingsCascadehas been preferred overviewerConfiguration,configurationCascade, andConfigurationCascade.There are no usages of the old API in our own code: https://sourcegraph.sourcegraph.com/search?q=context:sourcegraph+configurationcascade&patternType=literal.
Therefore, I'm calling it safe to remove.
Test plan
CI
Changelog
configurationCascadeandviewerConfigurationGraphQL API fields were removed. UsesettingsCascadeandviewerSettingsinstead.