Sourcebot git url ports #738
Draft
+89
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where whitespace between a prefix keyword and its value (e.g., 'repo: localhost:12030/testrepo' with a space after 'repo:') would cause the value to include the leading space, resulting in failed searches. The grammar captures text from the start of the prefix keyword to the end of the value, so any whitespace between them was included. By trimming the extracted value, we ensure proper matching. Also adds test cases for: - Repos with ports in URLs (e.g., localhost:12030/testrepo) - Multiple repos with ports in reposet filters - Combined repoNamesFilter and repoNamesFilterRegexp with ports Co-authored-by: michael <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes search failure for repositories with port numbers in their URLs.
The search parser was incorrectly including leading whitespace in the extracted value for prefix expressions (e.g.,
repo:), causing repository names likelocalhost:12030/testrepoto be used instead oflocalhost:12030/testrepo. This mismatch prevented searches from returning results. The fix adds a.trim()call to ensure only the actual value is used.Linear Issue: SOU-83