Skip to content

Added aria-describedby as step.id #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added aria-describedby as step.id #597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4579f8c
Added aria-describedby as step.id
webgurumike Dec 8, 2016
94a3518
Need to fire onStart regardless
webgurumike Dec 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/coffee/bootstrap-tour.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,9 @@
# Start tour from current step
start: (force = false) ->
@init force unless @_inited # Backward compatibility

if @_current is null
promise = @_makePromise(@_options.onStart(@) if @_options.onStart?)
@_callOnPromiseDone(promise, @showStep, 0)
@
promise = @_makePromise(@_options.onStart(@) if @_options.onStart?)
@_callOnPromiseDone(promise, @showStep, 0)


# Hide current step and show next step
next: ->
Expand Down Expand Up @@ -524,6 +522,7 @@
# Tip adjustment
$tip = if $element.data 'bs.popover' then $element.data('bs.popover').tip() else $element.data('popover').tip()
$tip.attr 'id', step.id
$element.attr 'aria-describedby', step.id

@_focus $tip, $element, step.next < 0
@_reposition $tip, step
Expand Down