getCurrentStep in onShow method returns 0 for first two steps #484
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly I have no idea if this PR is ok as the tests do not run at the moment. So please have a look...
Background:
I'm building an angular SPA with bootstrap-tour and overwrote the redirect method to use angulars $locate. (A regular redirect destroys the tour in an SPA immediatly.) Then, when bootstrap-tour tries to find the element of the next step, the redirect is not finished and the tour is destroyed.
To overcome this issue I use the onShow method as it blocks until a promise is resolved. So I choose the next steps element and wait for it and resolve the promise. That is exactly when I need tour.getCurrentStep().
It shows that on the first and second step tour.getCurrentStep() returns 0. So this PR resolves this issue but may cause troubles for devs using the onShow and getCurrentStep with off-by-one errors.