Conversation
collect_mellanox() and collect_nvidia_bluefield() both save get_component_versions.py output as "component_versions", but collect_nvidia_bmc_dump() did not, so a BMC techsupport tarball was missing the file its switch counterpart has. The tool only became available on the BMC with sonic-buildimage "[aspeed] Support get_component_versions.py on the SONiC BMC" (#29339); until then the omission was correct. Placed ahead of the early return taken when the hw-management BMC dump script is absent, so the capture does not depend on that script. Signed-off-by: Nikolay Mirin <nmirin@nvidia.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
nikamirrr
marked this pull request as ready for review
September 9, 2026 23:56
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
This PR has backport request label(s) for branch(es): msft-202608, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202608: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
Yakiv-Huryk
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
collect_mellanox()(scripts/generate_dump:1630) andcollect_nvidia_bluefield()(:2239) both saveget_component_versions.pyoutput into the techsupport tarball ascomponent_versions.collect_nvidia_bmc_dump()did not, so a BMC techsupport was missing a file its switch counterpart has.That was correct until the tool reached the BMC in sonic-net/sonic-buildimage#29339, which added aspeed support and reports
HW_MANAGEMENTandKERNELthere.How I did it
Placement is deliberate: the function returns early when
/usr/bin/hw-management-bmc-generate-dump.shis missing (:2261-2264), so appending at the end of the function would make the capture hostage to that script's presence. Hence the comment, so a later cleanup does not move it.The output filename matches the mellanox and BlueField paths, so tooling that reads
component_versionsworks unchanged across platforms.How to verify it
On an NVIDIA BMC:
component_versionsshould be present and contain the component/compilation/actual table.Manually tested on an NVIDIA BMC (Aspeed AST2700) running an image built from the
202608 branch: after
show techsupport, the tarball containscomponent_versionswiththe
HW_MANAGEMENTandKERNELrows. Without this change the file is absent from a BMCtechsupport. On an image whose
get_component_versions.pydoes not support the platform,save_cmdrecords the command failure and the dump completes normally — the same behaviour as any othersave_cmdwhose command is unavailable.Backport
No community backport requested. The change is needed on a 202608-based branch, which is
not a community release branch here; it will arrive there through the normal merge from
master rather than a cherry-pick.
Previous command output (if the output of a command-line utility has changed)
N/A — no CLI output changes; this only adds a file to the techsupport tarball.
New command output (if the output of a command-line utility has changed)
N/A