Skip to content

Conversation

@saksarav-nokia
Copy link
Contributor

What I did

Added multi asic support for sonic-clear queue wredcounters to fix sonic-net/sonic-buildimage#23566
Add --nonzero support for show queue wredcounters - (sonic-net/sonic-buildimage#22674)
Added multi asic support for counterpoll commands sonic-net/sonic-buildimage#23170
The PR #4012 broke some of the sonic-mgmt tests for multi-asic since the counterpoll command was mandating the asic-ns parameter. So the existing sonic-mgmt tests which configures the counterpoll commands without ns were failing and the PR #4012 is reverted. So changing the mandatory ns attribute to optional in this PR.

How I did it

Modified the wredstat and counterpoll sonic-utilities script to add muti-asic support and nonzero support

How to verify it

Verified the clear and show commands in T2 chassis and pizza box. Also verified that the counterpoll without ns option in multi-asic systems work and configures in global ns config_db and the show command reflects this config.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…poll , --nonzero support for show queue wredcounters

* Add multi-asic support for sonic-clear queue wredcounters

Signed-off-by: saksarav <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saksarav-nokia
Copy link
Contributor Author

@vmittal-msft @saiarcot895 , please review it.
@saiarcot895 , i I have changed the namespace parameter in the counterpoll command to be optional and verified in the multi-asic systems that the ns is not mandatory parameter

admin@ixre-egl-board3:$ show platform summary
Platform: x86_64-nokia_ixr7250e_36x400g-r0
HwSKU: Nokia-IXR7250E-36x400G
ASIC: broadcom
ASIC Count: 2
Model Number: N/A
Hardware Revision: 56
Switch Type: voq
admin@ixre-egl-board3:
$
admin@ixre-egl-board3:~$ counterpoll queue ?
Usage: counterpoll queue [OPTIONS] COMMAND [ARGS]...

Queue counter commands

Options:
-n, --namespace [asic0|asic1] Namespace name
--help Show this message and exit.

Commands:
disable Disable queue counter query
enable Enable queue counter query
interval Set queue counter query interval
admin@ixre-egl-board3:$ counterpoll queue enable
admin@ixre-egl-board3:
$
admin@ixre-egl-board3:$ counterpoll queue -n asic0 disable
admin@ixre-egl-board3:
$ counterpoll queue -n asic0 enable
admin@ixre-egl-board3:~$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug : 'sonic-clear queue wredcounters' does not clear the wredcounters

2 participants