Fix breakage for smartswitch usecase #3999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
tagging @dgsudharsan as well. |
Refer to sonic-net/sonic-buildimage#19638 The previous PR (sonic-net#3979) inadvertantly caused the above issue. This commit fixes that by connecting to zmq from fpmsyncd using the vrf as well (if one is configured)
venkit-nexthop
force-pushed
the
master
branch
from
61896f1 to
6ef904d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run Azure.sonic-swss |
|
Commenter does not have sufficient privileges for PR 3999 in repo sonic-net/sonic-swss |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/AzurePipelines run Azure.sonic-swss |
|
Commenter does not have sufficient privileges for PR 3999 in repo sonic-net/sonic-swss |
Contributor
Author
|
/AzurePipelines run Azure.sonic-swss |
|
Commenter does not have sufficient privileges for PR 3999 in repo sonic-net/sonic-swss |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Make fpmsyncd use the mgmt vrf to bind to zmq when configured.
Why I did it
Refer to sonic-net/sonic-buildimage#19638 The previous PR (#3979) inadvertantly caused the above issue.
This commit fixes that by connecting to zmq from fpmsyncd using the vrf as well (if one is configured)
How I verified it
By ensuring that when mgmt vrf is configured, FRR routes are programmed correctly via orchagent.
I also ran test_gnmi_zmq.py with the following diff and it ran successfully.
Details if related