-
Notifications
You must be signed in to change notification settings - Fork 630
Fix Orchagent crashes from port down cnt conversion out of range. #3889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix Orchagent crashes from port down cnt conversion out of range. #3889
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
it looks like failed as 2025-09-17T18:59:11.7239608Z Traceback (most recent call last): do not look like related to the change |
ERROR p4rt/test_l3.py::TestP4RTL3::test_IPv4RouteWithNexthopAddUpdateDeletePass does not look like related to the chagne |
/Azp run Azure.sonic-swss |
Commenter does not have sufficient privileges for PR 3889 in repo sonic-net/sonic-swss |
/Azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
@jfeng-arista please rebase |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
updated and all check passed |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@prsunny can you help merge this. |
When a fabric link keep flaky for a long time, Orchagent could crash with the out of range issue. It crashed at the convering the link down count number field from state_db to a uint8_t. This field is a cumulated number of the number of times of a link down, so to prevent out of range issue, it should convert the value to a larger type, such as uint64_t.
The issue is tracked at sonic-net/sonic-buildimage#24020
This PR revisit the related code and convert to related fields to uint64_t.
What I did
Why I did it
How I verified it
Details if related