Skip to content

Ensure RedisPipeline dtor not to throw #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure RedisPipeline dtor not to throw #1115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ece2aa5
Ensure RedisPipeline dtor not to throw
qiluo-msft Nov 26, 2025
4b26e52
Strict noexcept
qiluo-msft Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions common/redispipeline.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,38 @@ class RedisPipeline {
lastHeartBeat = std::chrono::steady_clock::now();
}

~RedisPipeline() {
if (m_ownerTid == gettid())
~RedisPipeline() noexcept {
try
{
// call flush from different thread will trigger race condition issue.
flush();
std::string dbName = getDbName();

if (m_ownerTid == gettid())
{
// call flush from different thread will trigger race condition issue.
try
{
flush();
}
catch (const std::exception& e)
{
SWSS_LOG_ERROR("Exception during RedisPipeline flush in destructor: %s, Database: %s", e.what(), dbName.c_str());
}
}
else
{
SWSS_LOG_NOTICE("RedisPipeline dtor is called from another thread, possibly due to exit(), Database: %s", dbName.c_str());
}

delete m_db;
}
else
catch (const std::exception& e)
{
SWSS_LOG_NOTICE("RedisPipeline dtor is called from another thread, possibly due to exit(), Database: %s", getDbName().c_str());
fprintf(stderr, "Exception during RedisPipeline destructor: %s\n", e.what());
}
catch (...)
{
fprintf(stderr, "Unknown exception during RedisPipeline destructor\n");
}

delete m_db;
}

redisReply *push(const RedisCommand& command, int expectedType)
Expand Down
Loading