[sonic-db-cli] Fix argument parsing skipping namespace #1111
Conversation
Signed-off-by: Connor Roos <[email protected]>
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
croos12
changed the title
croos12
changed the title
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
croos12
changed the title
|
@qiluo-msft can you review this PR? It fixes a bug that was introduced for multi-asic after this PR: #1070 |
|
How did you test (old code vs this PR)? Could you add unit test? |
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
Code lgtm. Suggest add test result in PR description and consider adding testcases.
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft we have unit tests that should cover this, but it looks like the behavior is not consistent. I had to test it by running it directly on the switch with print statements (this switch was a smartswitch so it had dpu databases but not asics) and I could see that the tool was not populating the namespace variable from the parameter : 
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
Fixes sonic-db-cli argument parsing skipping namespace argument by explicitly setting the options in getopt to select the next space delimitated argument to be namespace and container_name