CPU port queues support #182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Sreenivasan <[email protected]>
Collaborator
|
Can one of the admins verify this patch? |
This was referenced Dec 15, 2020
qiluo-msft
reviewed
Apr 5, 2021
| else: | ||
| port_queue_list_map[int(port_index)].append(int(queue_index)) | ||
| match_port_name = re.match(port_util.SONIC_CPU_PORT_RE_PATTERN, port_name) | ||
| if match_port_name is None: |
Contributor
There was a problem hiding this comment.
if match_port_name is None: [](start = 8, length = 27)
If it is not None: continue.
So we can keep below at original indentation level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prabhu Sreenivasan [email protected]
HLD: sonic-net/SONiC#743
- What I did
Avoid unwanted error logs introduced with CPU queues.
- How I did it
Skip CPU queues while creating port queue stat maps.
- How to verify it
Check syslog for snmp errors
** Depends on PRs**
sonic-net/sonic-swss#1544
sonic-net/sonic-py-swsssdk#98
Related PRs
sonic-net/sonic-sairedis#732
sonic-net/sonic-utilities#1314