Skip to content

Conversation

@Junchao-Mellanox
Copy link
Contributor

@Junchao-Mellanox Junchao-Mellanox commented Nov 17, 2025

Why I did this

SAI starts to support customer SAI header a few months ago. During integration with custom SAI header, I found some issues. This PR is to fix them. The PR also add a custom flag to VID and RID.

How I did this

  1. sonic-sairedis should compile with custom headers
  2. sonic vs sai should install custom headers to /usr/bin/sai
  3. add a custom flag in VID and RID

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft November 17, 2025 08:35
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox force-pushed the master-customer-header-upstream branch from 58d624e to 2641eae Compare November 17, 2025 09:49
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox force-pushed the master-customer-header-upstream branch from 2641eae to 8778998 Compare November 17, 2025 10:20
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox force-pushed the master-customer-header-upstream branch from 8778998 to bee9d3a Compare November 17, 2025 10:56
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox force-pushed the master-customer-header-upstream branch from bee9d3a to c032b90 Compare November 18, 2025 01:24
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox force-pushed the master-customer-header-upstream branch from c032b90 to 3a5b141 Compare November 18, 2025 06:24
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox
Copy link
Contributor Author

Hi @kcudnik , checker failed due to "/usr/bin/ld: final link failed: No space left on device", could you please suggest who can provide help?

@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review November 20, 2025 07:36
@kcudnik
Copy link
Collaborator

kcudnik commented Nov 20, 2025

Hi @kcudnik , checker failed due to "/usr/bin/ld: final link failed: No space left on device", could you please suggest who can provide help?

im no longermember of this project, plese ask Guohan

@Junchao-Mellanox
Copy link
Contributor Author

@saiarcot895 , could you please suggest who can handle the checker issue?

@Junchao-Mellanox
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox
Copy link
Contributor Author

Hi @lguohan , could you please suggest who may help review this PR? Thanks!

@lguohan
Copy link
Contributor

lguohan commented Nov 25, 2025

what is the use case for custom SAI header? can you help to elaborate more?

@Junchao-Mellanox
Copy link
Contributor Author

what is the use case for custom SAI header? can you help to elaborate more?

Hi @lguohan , it is an existing feature is SAI opencomputeproject/SAI@6168071. The readme file described the feature well:


SAI/custom is designed to hold custom headers provided by vendors.

By default this directory is empty, and no custom headers are present.  If
vendor want to provide custom headers, it can just simply copy custom headers
to that directory, and automatically that directory will be used by meta parser
to generate metadata for custom headers as well.

There is requirement that custom headers must still follow style convention
as regular headers.

This directory SAI/doc/custom-headers contains sample custom headers and how
they should look like. Base file is saicustom.h file which must be present if
vendor wants to add custom headers.

Custom headers, can extend existing object type, api, stats, attributes and
provide new apis and totally new enums.

Examing provided examples in this directory. If there will be problem with
custom headers, meta parser will provide error/warning message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants