-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fixes #24661: Update reference to sonic-dash-ha and sonic-swss-common #24663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes #24661: Update reference to sonic-dash-ha and sonic-swss-common #24663
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yue Gao <[email protected]>
b32dec1 to
18a542a
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please note that the sonic-swss-common submodule update PR has been failing for more than a month: #24285. Looking at a commit prior to sonic-net/sonic-swss-common#1113, de7e501, there have been test failures for t0, multi-asic-t1, and t2. For multi-asic-t1, when running I'm suspecting sonic-net/sonic-swss-common#1070 to be the culprit, but need to verify. |
|
both multiasic and t2 failed due to testbed prepare failed: Prepare testbed failed: testbed_q_sonic-elastictest-prod-vmss-D16s-v5-australiaeast_59157 for CELERY_TASK_TIMEOUT. any known outage? |
|
@yue-fred-gao See my previous comment. T2 is almost certainly the same reason ( |
|
For multi-ASIC T1 and T2, sonic-net/sonic-swss-common#1111 is required for swss-common submodule update. |
|
sonic-net/sonic-swss-common#1111 is merged. |
Signed-off-by: Yue Gao <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Updated. Hope it passes this time. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 and @qiluo-msft , multiasic test failed to start topo. t0 seems ntp sync failed. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #24661
Why I did it
sonic-buildimage is broken due to a PR sonic-net/sonic-swss-common#1113. The issue is that libswsscommon is built from src/sonic-swss-common mounted by sonic-buildimage but rust in sonic-swss is pulled directly from swss-common master branch. libswsscommon lags behind rust swss-common crate and causes the compilation error. We need to update ref of swss-common in sonic-buildimage to the latest.
Work item tracking
How I did it
Update references to sonic-swss-common and sonic-dash-ha
How to verify it
Run build in sonic-buildimage and passed
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)