Skip to content

Conversation

@yue-fred-gao
Copy link
Contributor

Fixes #24661

Why I did it

sonic-buildimage is broken due to a PR sonic-net/sonic-swss-common#1113. The issue is that libswsscommon is built from src/sonic-swss-common mounted by sonic-buildimage but rust in sonic-swss is pulled directly from swss-common master branch. libswsscommon lags behind rust swss-common crate and causes the compilation error. We need to update ref of swss-common in sonic-buildimage to the latest.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Update references to sonic-swss-common and sonic-dash-ha

How to verify it

Run build in sonic-buildimage and passed

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yue-fred-gao yue-fred-gao requested a review from lguohan as a code owner December 1, 2025 16:11
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yue-fred-gao yue-fred-gao force-pushed the fix_broken_build_unwrap branch from b32dec1 to 18a542a Compare December 1, 2025 16:24
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft
qiluo-msft previously approved these changes Dec 1, 2025
@saiarcot895
Copy link
Contributor

Please note that the sonic-swss-common submodule update PR has been failing for more than a month: #24285. Looking at a commit prior to sonic-net/sonic-swss-common#1113, de7e501, there have been test failures for t0, multi-asic-t1, and t2.

For multi-asic-t1, when running sonic-db-cli with -n specified and any value passed in for the ASIC, it fails with:

admin@vlab-08:~$ sonic-db-cli -n asic0 PING
An exception of type SonicDBConfig already initialized occurred. Arguments:
sonic-db-cli -n asic0 PING
admin@vlab-08:~$ sonic-db-cli -n asic899 PING
An exception of type SonicDBConfig already initialized occurred. Arguments:
sonic-db-cli -n asic899 PING
admin@vlab-08:~$ sonic-db-cli -n as899 PING
An exception of type SonicDBConfig already initialized occurred. Arguments:
sonic-db-cli -n as899 PING

I'm suspecting sonic-net/sonic-swss-common#1070 to be the culprit, but need to verify.

@yue-fred-gao
Copy link
Contributor Author

both multiasic and t2 failed due to testbed prepare failed: Prepare testbed failed: testbed_q_sonic-elastictest-prod-vmss-D16s-v5-australiaeast_59157 for CELERY_TASK_TIMEOUT. any known outage?

@saiarcot895
Copy link
Contributor

@yue-fred-gao See my previous comment. T2 is almost certainly the same reason (config load_minigraph is hanging, I'm guessing because per-instance database containers aren't coming up.)

@saiarcot895
Copy link
Contributor

For multi-ASIC T1 and T2, sonic-net/sonic-swss-common#1111 is required for swss-common submodule update.

@qiluo-msft
Copy link
Collaborator

sonic-net/sonic-swss-common#1111 is merged.
@yue-fred-gao Could you move sonic-swss-common submodule again in this PR?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yue-fred-gao
Copy link
Contributor Author

sonic-net/sonic-swss-common#1111 is merged. @yue-fred-gao Could you move sonic-swss-common submodule again in this PR?

Updated. Hope it passes this time.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yue-fred-gao
Copy link
Contributor Author

@saiarcot895 and @qiluo-msft , multiasic test failed to start topo. t0 seems ntp sync failed.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: swss build failure on latest sonic-swss-common

4 participants