Skip to content

Single-ASIC VOQ proposal #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Single-ASIC VOQ proposal #2008

wants to merge 9 commits into from
+147 −0

Conversation

lakshmi-nexthop
Copy link

Details for supporting VOQ mode in single ASIC SONiC switch systems.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@anilpannala anilpannala moved this to 📋 In Plan Features in SONiC 202511 Release Jun 12, 2025
@rlhui rlhui requested a review from arlakshm June 17, 2025 14:27
arlakshm
arlakshm reviewed Jun 18, 2025
View reviewed changes
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

arlakshm
arlakshm previously approved these changes Jul 1, 2025
View reviewed changes
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@lakshmi-nexthop
Update single_asic_voq.md
3d85b9c 
updates to use chassis db config file
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@deepak-singhal0408
Copy link

@arlakshm could you sign-off this HLD? thanks,

arista-nwolfe
arista-nwolfe reviewed Aug 6, 2025
View reviewed changes
Copy link

@arista-nwolfe arista-nwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HLD doesn't talk about what to do with the existing internal ports for single-asic VOQ systems.
I.E. Ethernet-IB0 and Ethernet-Rec0
I believe neither of these ports are needed for single-asic VOQ and some changes will be required in mirrororch.cpp to avoid requiring Ethernet-Rec0 for everflow.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@lakshmi-nexthop
Copy link
Author

The HLD doesn't talk about what to do with the existing internal ports for single-asic VOQ systems. I.E. Ethernet-IB0 and Ethernet-Rec0 I believe neither of these ports are needed for single-asic VOQ and some changes will be required in mirrororch.cpp to avoid requiring Ethernet-Rec0 for everflow.

updated the orchagent section.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

kenneth-arista
kenneth-arista reviewed Aug 20, 2025
View reviewed changes
kenneth-arista
kenneth-arista reviewed Aug 20, 2025
View reviewed changes
kenneth-arista
kenneth-arista reviewed Aug 20, 2025
View reviewed changes
@lakshmi-nexthop
Update Bgpconfd section
8cfd38a 
TSA applies for both chassis and non chassis case.
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@abdosi
Copy link
Contributor

abdosi commented Sep 17, 2025

  1. Egress Everflow do we need Recirc Port ==> Waiting for BRCM
  2. Do recirc port just for base use case of Regular Ingress Mirroring
    2.1 Regular Ingress mirroring does not need Recirc Port
    2.2 Regular Ingress Mirroring + Policer needs Recirc Port .

@arlakshm : Arista/Nexthop wants to starts with Recirc Port (maintain backward compatibility) and later can be removed as optimization. Please help close on this.

@abdosi
Copy link
Contributor

abdosi commented Sep 17, 2025 •
edited
Loading

Please add code PR links here.

@lakshmi-nexthop
Update single_asic_voq.md
5bdfae8 
recirc ports are going to be present as per discussions.
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@lakshmi-nexthop
Copy link
Author

lakshmi-nexthop commented Sep 24, 2025 •
edited
Loading

code PR:

@abdosi
Copy link
Contributor

abdosi commented Oct 1, 2025

2. Do recirc port just for base use case of Regular Ingress Mirroring
2.1 Regular Ingress mirroring does not need Recirc Port
2.2 Regular Ingress Mirroring + Policer needs Recirc Port .

Nexthop confirmed both Ingress and Egress Everflow works fine with Recirc Port. Need to check for Policier.

@abdosi
Copy link
Contributor

abdosi commented Oct 1, 2025

@arista-nwolfe / @arlakshm please sign-off to merge this.

arista-nwolfe
arista-nwolfe reviewed Oct 1, 2025
View reviewed changes
@lakshmi-nexthop
Update single_asic_voq.md
eb588f9 
inband ports info
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlakshm arlakshm

+3 more reviewers

@kenneth-arista kenneth-arista

@eswaran-nexthop eswaran-nexthop

@arista-nwolfe arista-nwolfe

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@lakshmi-nexthop lakshmi-nexthop

Labels
None yet
Projects
SONiC 202511 Release
Status: 📋 In Plan Features
SONiC Chassis
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lakshmi-nexthop @mssonicbld @deepak-singhal0408 @abdosi @arlakshm @kenneth-arista @arista-nwolfe @eswaran-nexthop