Add Spree::ZERO constant
#6291
Merged
Add Spree::ZERO constant
#6291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6291 +/- ##
==========================================
+ Coverage 88.95% 88.97% +0.01%
==========================================
Files 860 861 +1
Lines 18422 18416 -6
==========================================
- Hits 16387 16385 -2
+ Misses 2035 2031 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamhoff
force-pushed
the
promotions-zero
branch
4 times, most recently
from
9844f2e to
8780f63
Compare
tvdeyen
approved these changes
Jun 18, 2025
Ruby's `BigDecimal` library does not come with a constant that denotes zero. We don't need to be creating a new zero every time we need one. Also, there's even a Rubocop that tells people to use an integer for integer-type BigDecimal instantiations, but a string for float-type BigDecimals (See https://github.com/rubocop/rubocop-performance/blob/master/lib/rubocop/cop/performance/big_decimal_with_numeric_argument.rb) This all to say: Let's have a constant in the codebase that is zero. We can just reference it, we don't need so many zeros.
This file is currently only loaded when loading either `Spree::Calculator` or `Spree::PaymentMethod`. We can use Rails' autoloading mechanism instead. This makes running the spec for the `Preferable` module run through on its own.
`String#to_d` will never, ever raise an ArgumentError. I tried with `Object.new.to_s.to_d`. This raises our test coverage for these files. This was originally introduced to guard against weird behaviour of Ruby 2.4, which we do not support any longer.
jarednorman
approved these changes
Jun 23, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Solidus Public Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ruby's
BigDecimallibrary does not come with a constant that denotes zero. We don't need to be creating a new zero every time we need one. Also, there's even a Rubocop that tells people to use an integer for integer-type BigDecimal instantiations, but a string for float-type BigDecimals (Seehttps://github.com/rubocop/rubocop-performance/blob/master/lib/rubocop/cop/performance/big_decimal_with_numeric_argument.rb)
This all to say: Let's have a constant in the codebase that is zero. We can just reference it, we don't need so many zeros.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: