Skip to content

Alternative conflict resolutions after repository conversion for the translation bot#33

Open
cameel wants to merge 2 commits intodevelopfrom
alternative-conflict-resolutions
Open

Alternative conflict resolutions after repository conversion for the translation bot#33
cameel wants to merge 2 commits intodevelopfrom
alternative-conflict-resolutions

Conversation

@cameel
Copy link
Contributor

@cameel cameel commented Jul 22, 2022

Hello!

I have just finished converting this repository to a form compatible with our new translation bot (Introducing the Translations PR Bot!). Unfortunately this conversion does no accurately preserve merges in all cases. I had to redo some conflict resolutions and choose one version in each case. This PR contains the versions that were not chosen.

Normally I would be able to tell which version is good by looking at the original main branch and making the same choice. The problem is that in many cases the choice was not made at all - i.e. the conflict was not edited to select one version but instead committed together with the <<<<<<<<<</==========/>>>>>>>>>> conflict markers.

Also there were some conflicts where the decision was to remove some text and here's a chance that it was done by accident.

It's actually possible that none of the changes here are correct. Ideally that should be the case. Unfortunately I don't know Persian so I can't tell myself. Please review it and tell me which parts are wrong and should be removed from the PR and which are good and should be kept. Then I'll update the PR and we can merge what's left of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant