Skip to content

Conversation

Denperidge
Copy link

Hi! The commits have a description of what has been changed, but to summarise a bit:

  • Fixed readline not accepting input (on node 18)
  • Moved duplicate code into their own utils file
  • go() now loads in Matrix rooms
  • Matrix credentials are now configurable through environment variables, the same way as the other config options

I've also been working on adding support for encryption but - as opposed to the matrix-bot-sdk, matrix-js-sdk seems to require a lot of manual configuration for this, so no luck as of yet. The code is non functional and thus not in this commit, but you can view it here

Changes:
- Hardcoded Matrix vars in gitter-solid & terminal-app are now fallback
- Documented env var configuration options in README
- Added .env.example
In node v18, map.keys().forEach doesn't exist. It is now a for of loop
General changes:
- setRoomList moved to matrix-utils
- show & short moved to utils

Gitter-Solid changes:
- go() now loads Matrix rooms
- renamed doRoom() { function show }
  to doRoom() { function doRoomShow }
  This to fix ambiguity with show, show (now doRoomShow), and showRoom
@madnificent
Copy link

@Denperidge thanks for looking at this. Could we strip encryption using Pantalaimon https://github.com/matrix-org/pantalaimon ? Did not manage to set it up without really reading the readme.

@Denperidge
Copy link
Author

Oh that might work, great find! I'll take a look at it tomorrow.

The problem with the matrix-js-sdk encryption handling is that - as far as I've been able to find - it seems to require visual+manual verification (e.g. emoji key from other device). Hopefully pantalaimon has this built-in, without having to add too much extra installation steps for this project.

@madnificent
Copy link

🤔 pantalaimon lets you do that through a CLI but that's because it can show these images... This script running through a CLI, it should be possible too. This is only on setup, I believe.

If there is no timeout, perhaps we can handle this in data (though I know of no such model).

@Denperidge Denperidge mentioned this pull request Feb 10, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants