Repository navigation
p-token: Add ui amount precision tests - #98
Merged
Merged
Conversation
joncinque
reviewed
Oct 3, 2025
joncinque
left a comment
joncinque
left a comment
Contributor
There was a problem hiding this comment.
Looks great! I'll approve once the git deps are removed
febo
marked this pull request as ready for review
October 3, 2025 17:14
Contributor
Author
|
@joncinque Added the published crate. |
joncinque
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In practice, mints can have up to
u8::MAXprecision. BothAmountToUiAmountandUiAmountToAmountuse the decimal value as precision to convert an amount to/from a string representation.Solution
This PR adds tests to specifically check the behaviour when the maximum precision value is used.
Note that this PR depends on anza-xyz/pinocchio#252.