fix(cli): preserve program names from anchor.toml when scaffold runbook

[MicaiahReid]

Fixes #679

[greptile-apps]

Greptile Summary

This PR fixes a bug where program names from Anchor.toml and Cargo.toml were being mangled by convert_case::Case::Snake, which splits at digit–letter transitions (e.g. v2 → v_2). The fix replaces the snake_case conversion with name-preserving logic in both the Anchor manifest path and the Cargo manifest fallback path.

• In anchor.rs, program name keys from [programs.localnet] are now cloned verbatim instead of run through to_case(Case::Snake).
• In utils.rs, the name resolution prefers [lib] name from Cargo.toml (already underscore-safe) and falls back to package.name.replace('-', \"_\") — a simple substitution that does not split digits. Both paths are covered by new regression tests using tempfile.

Confidence Score: 5/5

Safe to merge — the change is a targeted fix to a name-mangling bug with full test coverage and no regressions introduced.

Both affected code paths (Anchor manifest and Cargo manifest) are corrected with minimal, focused changes. The old convert_case calls are removed entirely, and the replacement logic (clone() / replace('-', "_")) is straightforwardly correct. Three new unit tests and one integration test assert the expected behavior, including the digit-splitting regression case. No existing behavior is broken for names that did not contain digits.

No files require special attention.

Important Files Changed

Filename	Overview
crates/cli/src/scaffold/anchor.rs	Removes to_case(Case::Snake) from program name deserialization; adds a regression test for name preservation.
crates/cli/src/scaffold/utils.rs	Adds Lib struct with optional name, switches fallback to replace('-', "_"), and adds three new unit tests covering all name-resolution branches.
crates/cli/Cargo.toml	Adds tempfile as a dev-dependency to support filesystem-based unit tests in utils.rs.
crates/sdk-node/package-lock.json	Replaces empty optional stubs for platform-specific surfpool packages with full v1.3.0 entries from the npm registry.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Scaffold runbook] --> B{Anchor.toml present?}
    B -- yes --> C[Parse AnchorManifest]
    C --> D["deser_programs()"]
    D --> E["name.clone() ✅\n(was: to_case(Case::Snake) ❌)"]
    E --> F[program_name preserved verbatim]

    B -- no --> G[Walk workspace Cargo.toml members]
    G --> H{lib.name present?}
    H -- yes --> I[use lib.name directly]
    H -- no --> J["package.name.replace('-', '_') ✅\n(was: to_case(Case::Snake) ❌)"]
    I --> K[program_name preserved]
    J --> K

    F --> L[Construct .so path & check existence]
    K --> L
    L --> M[ProgramMetadata]

Loading

_{Reviews (5): Last reviewed commit: "chore: update package-lock" | Re-trigger Greptile}

[greptile-apps]

The name field on Lib is non-optional, which means CargoManifestFile::from_manifest_str will fail with a deserialization error for any Cargo.toml that has a [lib] section without an explicit name key. This is extremely common — both in this very repository (crates/core, crates/types, crates/sdk all have [lib] path = "src/lib.rs" with no name) and in standard Anchor/Solana projects where [lib] crate-type = ["cdylib", "lib"] is typical. When the workspace scanner hits any such member, scaffolding fails entirely rather than falling back to the package name.

[MicaiahReid]

Fixed: 3daf01e

[greptile-apps]

Once Lib.name becomes Option<String>, the fallback chain here needs to use and_then instead of map so a Lib present but with no name still falls through to the package-name logic.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[MicaiahReid]

Fixed: 3daf01e

[MicaiahReid]

@greptileai I've addressed your comments - ready for rereview

[greptile-apps]

Want your agent to iterate on Greptile's feedback? Try greploops.