Open
Conversation
Member
Author
|
Maybe instead of defining method validations on port configuration level (as implemented in this PR) we can change the bus.registerLocal api to accept structured method definitions instead of plain functions. E.g. In https://github.com/softwaregroup-bg/ut-bus/blob/master/serviceBus.js#L80 Instead of: {
'a.b.c': function() {},
'x.y.z': function() {}
}We can add support for registering modules represented with more complex structures like: {
'a.b.c': {
handler: function() {},
validation: ...
},
'x.y.z': {
handler: function() {},
validation: ...
}
}This way we can we add message validations on method level and leave each module define it's own message formats without needing to import any validations in the http server |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per method validations