Add void to unhandled promises

.eslintrc.js

@@ -158,7 +158,8 @@ module.exports = {
         '@typescript-eslint/no-non-null-assertion': 'error',
         '@typescript-eslint/switch-exhaustiveness-check': 'error',
         '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
-        '@typescript-eslint/no-floating-promises': 'off',
+        '@typescript-eslint/no-floating-promises': 'error',
+        'no-void': 'off',
         '@typescript-eslint/no-import-type-side-effects': 'error',
         '@typescript-eslint/array-type': ['error', {default: 'array-simple'}],
         '@typescript-eslint/max-params': ['error', {max: 10}],

contributingGuides/philosophies/ASYNC.md

@@ -10,7 +10,7 @@ Async code is everywhere in our app: API calls, storage access, background tasks
 
 ## Rules
 
-### -Use async/await for sequential flows
+### - Use async/await for sequential flows
    When order matters, `async/await` expresses intent in a clear, linear style.
    Example: Upload a file → Parse it → Save results.
 

src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.tsx

@@ -42,8 +42,8 @@
                         if (isDownloading || isOffline || !sourceID) {
                             return;
                         }
                         setDownload(sourceID, true);
-                        fileDownload(sourceURLWithAuth, displayName, '', isMobileSafari()).then(() => setDownload(sourceID, false));
+                        void fileDownload(sourceURLWithAuth, displayName, '', isMobileSafari()).then(() => setDownload(sourceID, false));
                     }}
                     onPressIn={onPressIn}
                     onPressOut={onPressOut}

src/components/AttachmentModal.tsx

@@ -264,7 +264,7 @@ function AttachmentModal({
 
         if (typeof sourceURL === 'string') {
             const fileName = type === CONST.ATTACHMENT_TYPE.SEARCH ? getFileName(`${sourceURL}`) : file?.name;
-            fileDownload(sourceURL, fileName ?? '', undefined, undefined, undefined, undefined, undefined, !draftTransactionID);
+            void fileDownload(sourceURL, fileName ?? '', undefined, undefined, undefined, undefined, undefined, !draftTransactionID);
         }
 
         // At ios, if the keyboard is open while opening the attachment, then after downloading
@@ -437,7 +437,7 @@ function AttachmentModal({
                     }
 
                     if (isReplaceReceipt.current) {
-                        InteractionManager.runAfterInteractions(() => {
+                        void InteractionManager.runAfterInteractions(() => {
                             Navigation.navigate(
                                 ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
                                     iouAction ?? CONST.IOU.ACTION.EDIT,

src/components/AutoSubmitModal.tsx

@@ -35,7 +35,7 @@ function AutoSubmitModal() {
     const StyleUtils = useStyleUtils();
 
     const onClose = useCallback((willShowAgain: boolean) => {
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             if (!willShowAgain) {
                 dismissASAPSubmitExplanation(true);
             } else {

src/components/AvatarCropModal/AvatarCropModal.tsx

@@ -120,7 +120,7 @@
             return;
         }
         // We need to have image sizes in shared values to properly calculate position/size/animation
         ImageSize.getSize(imageUri).then(({width, height, rotation: originalRotation}) => {
             // On Android devices ImageSize library returns also rotation parameter.
             if (originalRotation === 90 || originalRotation === 270) {
                 originalImageHeight.set(width);
@@ -316,7 +316,7 @@
 
         cropOrRotateImage(imageUri, [{rotate: rotation.get() % 360}, {crop}], {compress: 1, name, type})
             .then((newImage) => {
-                InteractionManager.runAfterInteractions(() => {
+                void InteractionManager.runAfterInteractions(() => {
                     onClose?.();
                 });
                 onSave?.(newImage);

src/components/ContactPermissionModal/index.native.tsx

@@ -20,7 +20,7 @@
             onFocusTextInput();
             return;
         }
         getContactPermission().then((status) => {
             // Permission hasn't been asked yet, show the soft permission modal
             if (status !== RESULTS.DENIED) {
                 onFocusTextInput();
@@ -34,8 +34,8 @@
 
     const handleGrantPermission = () => {
         setIsModalVisible(false);
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             requestContactPermission().then((status) => {
                 onFocusTextInput();
                 if (status !== RESULTS.GRANTED) {
                     return;
@@ -50,7 +50,7 @@
         onDeny(RESULTS.DENIED);
         // Sometimes, the input gains focus when the modal closes, but the keyboard doesn't appear.
         // To fix this, we need to call the focus function after the modal has finished closing.
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             onFocusTextInput();
         });
     };

src/components/DatePicker/index.tsx

@@ -50,7 +50,7 @@
 
     useEffect(() => {
         if (shouldSaveDraft && formID) {
             setDraftValues(formID, {[inputID]: selectedDate});
         }
         if (selectedDate === value || !value) {
             return;
@@ -95,7 +95,7 @@
     };
 
     useEffect(() => {
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             calculatePopoverPosition();
         });
     }, [calculatePopoverPosition, windowWidth]);
@@ -105,7 +105,7 @@
             return;
         }
         isAutoFocused.current = true;
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             handlePress();
         });
     }, [handlePress, autoFocus]);

src/components/DeeplinkWrapper/index.website.tsx

@@ -68,7 +68,7 @@ function DeeplinkWrapper({children, isAuthenticated, autoAuthState, initialUrl}:
 
         if (isAuthenticated === false) {
             setHasShownPrompt(false);
-            Navigation.isNavigationReady().then(() => {
+            void Navigation.isNavigationReady().then(() => {
                 // Get initial route
                 const initialRoute = navigationRef.current?.getCurrentRoute();
                 setCurrentScreen(initialRoute?.name);

src/components/DotIndicatorMessage.tsx

@@ -82,7 +82,7 @@ function DotIndicatorMessage({messages = {}, style, type, textStyles, dismissErr
                         <TextLink
                             style={[StyleUtils.getDotIndicatorTextStyles(), styles.link]}
                             onPress={() => {
-                                fileDownload(message.source, message.filename).finally(() => dismissError());
+                                void fileDownload(message.source, message.filename).finally(() => dismissError());
                             }}
                         >
                             {translate('iou.error.saveFileMessage')}

src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx

@@ -47,7 +47,7 @@ function EmojiPickerMenu({onEmojiSelected, activeEmoji, ref}: EmojiPickerMenuPro
         setFilteredEmojis(emojiData);
         setHeaderIndices(headerData);
 
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             requestAnimationFrame(() => {
                 emojiListRef.current?.scrollToOffset({offset: 0, animated: false});
             });

src/components/FeatureTrainingModal.tsx

@@ -220,7 +220,7 @@ function FeatureTrainingModal({
     const {isKeyboardActive} = useKeyboardState();
 
     useEffect(() => {
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             if (!isModalDisabled) {
                 setIsModalVisible(false);
                 return;
@@ -347,7 +347,7 @@ function FeatureTrainingModal({
         Log.hmmm('[FeatureTrainingModal] Setting modal invisible');
         setIsModalVisible(false);
 
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             Log.hmmm(`[FeatureTrainingModal] Running after interactions - shouldGoBack: ${shouldGoBack}, hasOnClose: ${!!onClose}`);
 
             if (shouldGoBack) {

src/components/Form/FormProvider.tsx

@@ -254,7 +254,7 @@
                 return;
             }
 
             KeyboardUtils.dismiss().then(() => onSubmit(trimmedStringValues));
         }, [enabledWhenOffline, formState?.isLoading, inputValues, isLoading, network?.isOffline, onSubmit, onValidate, shouldTrimValues]),
         1000,
         {leading: true, trailing: false},
@@ -417,7 +417,7 @@
                     }
                     inputProps.onBlur?.(event);
                     if (isSafari()) {
-                        InteractionManager.runAfterInteractions(() => {
+                        void InteractionManager.runAfterInteractions(() => {
                             setIsBlurred(true);
                         });
                     }
@@ -437,7 +437,7 @@
                     });
 
                     if (inputProps.shouldSaveDraft && !formID.includes('Draft')) {
                         setDraftValues(formID, {[inputKey]: value});
                     }
                     inputProps.onValueChange?.(value, inputKey);
                 },

src/components/Form/FormWrapper.tsx

@@ -228,7 +228,7 @@ function FormWrapper({
                     if (!shouldScrollToEnd) {
                         return;
                     }
-                    InteractionManager.runAfterInteractions(() => {
+                    void InteractionManager.runAfterInteractions(() => {
                         requestAnimationFrame(() => {
                             formRef.current?.scrollToEnd({animated: true});
                         });

src/components/MoneyReportHeader.tsx

@@ -413,7 +413,7 @@
                 showDelegateNoAccessModal();
             } else if (isAnyTransactionOnHold) {
                 if (getPlatform() === CONST.PLATFORM.IOS) {
-                    InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true));
+                    void InteractionManager.runAfterInteractions(() => setIsHoldMenuVisible(true));
                 } else {
                     setIsHoldMenuVisible(true);
                 }
@@ -476,7 +476,7 @@
         if (!iouTransactionID || !reportID) {
             return;
         }
         markAsCashAction(iouTransactionID, reportID);
     }, [iouTransactionID, requestParentReportAction, transactionThreadReport?.reportID]);
 
     const getStatusIcon: (src: IconAsset) => React.ReactNode = (src) => (
@@ -1388,7 +1388,7 @@
                         }
                         // it's deleting transaction but not the report which leads to bug (that is actually also on staging)
                         // Money request should be deleted when interactions are done, to not show the not found page before navigating to goBackRoute
-                        InteractionManager.runAfterInteractions(() => {
+                        void InteractionManager.runAfterInteractions(() => {
                             deleteMoneyRequest(transaction?.transactionID, requestParentReportAction, duplicateTransactions, duplicateTransactionViolations);
                             removeTransaction(transaction.transactionID);
                         });
@@ -1429,7 +1429,7 @@
                     setIsDeleteReportModalVisible(false);
 
                     Navigation.goBack();
-                    InteractionManager.runAfterInteractions(() => {
+                    void InteractionManager.runAfterInteractions(() => {
                         deleteAppReport(moneyRequestReport?.reportID);
                     });
                 }}

src/components/MoneyRequestConfirmationList.tsx

@@ -1005,7 +1005,7 @@ function MoneyRequestConfirmationList({
     useFocusEffect(
         useCallback(() => {
             focusTimeoutRef.current = setTimeout(() => {
-                InteractionManager.runAfterInteractions(() => {
+                void InteractionManager.runAfterInteractions(() => {
                     blurActiveElement();
                 });
             }, CONST.ANIMATED_TRANSITION);

src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx

@@ -263,7 +263,7 @@
             return;
         }
 
-        InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadOlderChats(false)));
+        void InteractionManager.runAfterInteractions(() => requestAnimationFrame(() => loadOlderChats(false)));
     }, [loadOlderChats]);
 
     const onEndReached = useCallback(() => {
@@ -484,7 +484,7 @@
 
     const scrollToBottomForCurrentUserAction = useCallback(
         (isFromCurrentUser: boolean, reportAction?: OnyxTypes.ReportAction) => {
-            InteractionManager.runAfterInteractions(() => {
+            void InteractionManager.runAfterInteractions(() => {
                 setIsFloatingMessageCounterVisible(false);
                 // If a new comment is added from the current user, scroll to the bottom, otherwise leave the user position unchanged
                 if (!isFromCurrentUser || reportAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT) {
@@ -504,7 +504,7 @@
                 }
             });
         },
         [reportScrollManager, setIsFloatingMessageCounterVisible],
     );
 
     useEffect(() => {

src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

@@ -122,7 +122,7 @@ function MoneyRequestReportView({report, policy, reportMetadata, shouldDisplayRe
 
     const dismissReportCreationError = useCallback(() => {
         goBackFromSearchMoneyRequest();
-        InteractionManager.runAfterInteractions(() => removeFailedReport(reportID));
+        void InteractionManager.runAfterInteractions(() => removeFailedReport(reportID));
     }, [reportID]);
 
     // Special case handling a report that is a transaction thread

src/components/OptionRow.tsx

@@ -189,7 +189,7 @@ function OptionRow({
                                 result = Promise.resolve();
                             }
 
-                            InteractionManager.runAfterInteractions(() => {
+                            void InteractionManager.runAfterInteractions(() => {
                                 result?.finally(() => setIsDisabled(isOptionDisabled));
                             });
                         }}

src/components/Search/SearchRouter/SearchRouter.tsx

@@ -314,7 +314,7 @@ function SearchRouter({onRouterClose, shouldHideInputCaret, isSearchRouterDispla
 
             const setFocusAndScrollToRight = () => {
                 try {
-                    InteractionManager.runAfterInteractions(() => {
+                    void InteractionManager.runAfterInteractions(() => {
                         if (!textInputRef.current) {
                             Log.info('[CMD_K_DEBUG] Focus skipped - no text input ref', false, {
                                 actionId,

src/components/SidePanel/useSyncSidePanelWithHistory/index.ts

@@ -8,7 +8,7 @@ import navigationRef from '@libs/Navigation/navigationRef';
 import CONST from '@src/CONST';
 
 function toggleSidePanelWithHistory(isVisible: boolean) {
-    Navigation.isNavigationReady().then(() => {
+    void Navigation.isNavigationReady().then(() => {
         navigationRef.dispatch({
             type: CONST.NAVIGATION.ACTION_TYPE.TOGGLE_SIDE_PANEL_WITH_HISTORY,
             payload: {isVisible},

src/components/TestDrive/Modal/AdminTestDriveModal.tsx

@@ -16,7 +16,7 @@ function AdminTestDriveModal() {
 
     const navigate = () => {
         Log.hmmm('[AdminTestDriveModal] Navigate function called');
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             Log.hmmm('[AdminTestDriveModal] Calling Navigation.navigate()');
             Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
         });
@@ -27,7 +27,7 @@ function AdminTestDriveModal() {
         Navigation.dismissModal();
 
         Log.hmmm('[AdminTestDriveModal] Running after interactions');
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             if (!isAdminRoom(onboardingReport)) {
                 Log.hmmm('[AdminTestDriveModal] Not an admin room');
                 return;

src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx

@@ -94,7 +94,7 @@ function EmployeeTestDriveModal() {
 
                         Log.hmmm('[EmployeeTestDriveModal] Running after interactions');
                         Navigation.goBack();
-                        InteractionManager.runAfterInteractions(() => {
+                        void InteractionManager.runAfterInteractions(() => {
                             Log.hmmm('[EmployeeTestDriveModal] Calling Navigation.goBack() and Navigation.navigate()');
                             Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(CONST.IOU.ACTION.CREATE, CONST.IOU.TYPE.SUBMIT, transactionID, reportID));
                         });

src/components/TestDrive/TestDriveDemo.tsx

@@ -34,7 +34,7 @@ function TestDriveDemo() {
     });
 
     useEffect(() => {
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             setIsVisible(true);
             completeTestDriveTask();
         });
@@ -46,7 +46,7 @@ function TestDriveDemo() {
 
     const closeModal = useCallback(() => {
         setIsVisible(false);
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             Navigation.goBack();
 
             if (isAdminRoom(onboardingReport)) {

src/components/VideoPlayerContexts/PlaybackContext/index.tsx

@@ -79,7 +79,7 @@ function PlaybackContextProvider({children}: ChildrenProps) {
     );
 
     useEffect(() => {
-        Navigation.isNavigationReady().then(() => {
+        void Navigation.isNavigationReady().then(() => {
             // This logic ensures that resetVideoPlayerData is only called when currentReportID
             // changes from one valid value (i.e., not an empty string or '-1') to another valid value.
             // This prevents the video that plays when the app opens from being interrupted when currentReportID

src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

@@ -32,7 +32,7 @@ function VideoPopoverMenuContextProvider({children}: ChildrenProps) {
         if (typeof source === 'number' || !source) {
             return;
         }
-        fileDownload(addEncryptedAuthTokenToURL(source));
+        void fileDownload(addEncryptedAuthTokenToURL(source));
     }, [source]);
 
     const menuItems = useMemo(() => {

src/components/WideRHPContextProvider/index.tsx

@@ -237,7 +237,7 @@ function useShowWideRHPVersion(condition: boolean) {
      */
     useEffect(() => {
         return navigation.addListener('beforeRemove', () => {
-            InteractionManager.runAfterInteractions(() => {
+            void InteractionManager.runAfterInteractions(() => {
                 cleanWideRHPRouteKey(route);
             });
         });

src/hooks/useCheckIfRouteHasRemainedUnchanged.ts

@@ -49,7 +49,7 @@ function useCheckIfRouteHasRemainedUnchanged(videoUrl: string) {
 
     // Initialize and check if starting with the attachment modal
     useEffect(() => {
-        Navigation.isNavigationReady().then(() => {
+        void Navigation.isNavigationReady().then(() => {
             if (isOnInitialRenderedRouteRef.current !== undefined) {
                 return;
             }

src/hooks/useFilesValidation.tsx

@@ -90,7 +90,7 @@ function useFilesValidation(proceedWithFilesAction: (files: FileObject[]) => voi
 
     const hideModalAndReset = useCallback(() => {
         setIsErrorModalVisible(false);
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             resetValidationState();
         });
     }, [resetValidationState]);
@@ -305,7 +305,7 @@ function useFilesValidation(proceedWithFilesAction: (files: FileObject[]) => voi
         // the error modal is dismissed before opening the attachment modal
         if (!isValidatingReceipts && fileError) {
             setIsErrorModalVisible(false);
-            InteractionManager.runAfterInteractions(() => {
+            void InteractionManager.runAfterInteractions(() => {
                 if (sortedFiles.length !== 0) {
                     proceedWithFilesAction(sortedFiles);
                 }

src/hooks/useFirstRenderRoute.ts

@@ -12,7 +12,7 @@ function useFirstRenderRoute(focusExceptionRoutes?: ((initialRoute: string | nul
     const initialRoute = useRef<string | null>(null);
 
     useEffect(() => {
-        Navigation.isNavigationReady().then(() => {
+        void Navigation.isNavigationReady().then(() => {
             if (initialRoute.current) {
                 return;
             }

src/hooks/useOnboardingFlow.ts

@@ -49,7 +49,7 @@ function useOnboardingFlowRouter() {
 
     useEffect(() => {
         // This should delay opening the onboarding modal so it does not interfere with the ongoing ReportScreen params changes
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             // Prevent starting the onboarding flow if we are logging in as a new user with short lived token
             if (currentUrl?.includes(ROUTES.TRANSITION_BETWEEN_APPS) && isLoggingInAsNewSessionUser) {
                 return;

src/hooks/useRefreshKeyAfterInteraction/index.desktop.tsx

@@ -5,7 +5,7 @@ function useRefreshKeyAfterInteraction(defaultValue: string) {
     const [counter, setCounter] = useState(0);
 
     useEffect(() => {
-        InteractionManager.runAfterInteractions(() => {
+        void InteractionManager.runAfterInteractions(() => {
             setCounter((prev) => prev + 1);
         });
     }, []);

src/hooks/useRestoreInputFocus/index.android.ts

@@ -11,7 +11,7 @@ const useRestoreInputFocus = (isLostFocus: boolean) => {
         }
 
         if (!isLostFocus && keyboardVisibleBeforeLoosingFocusRef.current) {
-            InteractionManager.runAfterInteractions(() => {
+            void InteractionManager.runAfterInteractions(() => {
                 KeyboardController.setFocusTo('current');
             });
         }

src/hooks/useSearchHighlightAndScroll.ts

@@ -132,7 +132,7 @@ function useSearchHighlightAndScroll({
             triggeredByHookRef.current = true;
 
             // Trigger the search
-            InteractionManager.runAfterInteractions(() => {
+            void InteractionManager.runAfterInteractions(() => {
                 search({queryJSON, searchKey, offset, shouldCalculateTotals});
             });