Skip to content

Fix erlang:is_number BIF #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: old-swm
Choose a base branch
from
Open

Fix erlang:is_number BIF #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libAtomVM/bif.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,7 @@ term bif_erlang_is_number_1(Context *ctx, uint32_t fail_label, term arg1)
UNUSED(ctx);
UNUSED(fail_label);

//TODO: change to term_is_number
return term_is_any_integer(arg1) ? TRUE_ATOM : FALSE_ATOM;
return term_is_number(arg1) ? TRUE_ATOM : FALSE_ATOM;
}

term bif_erlang_is_pid_1(Context *ctx, uint32_t fail_label, term arg1)
Expand Down
2 changes: 1 addition & 1 deletion tests/erlang_tests/is_type.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

start() ->
Pid = self(),
test_is_type(hello, <<"hello">>, 10, [1, 2, 3], 5, Pid, make_ref(), {1, 2}).
test_is_type(hello, <<"hello">>, 10, [1, 2, 3], 5.5, Pid, make_ref(), {1, 2}).

test_is_type(A, B, I, L, N, P, R, T) ->
all_true(
Expand Down