Please review slcli

Author: username1901

SoftLayer/CLI/block/refresh.py

@@ -13,7 +13,7 @@
 def cli(env, volume_id, snapshot_id):
     """"Refresh a duplicate volume with a snapshot from its parent."""
     block_manager = SoftLayer.BlockStorageManager(env.client)
-    resp = block_manager.refresh_dupe(volume_id, snapshot_id)               #remove dep_ in refresh_dep_dupe
+    resp = block_manager.refresh_dupe(volume_id, snapshot_id)
 
     click.echo(resp)
 

SoftLayer/CLI/file/refresh.py

@@ -11,8 +11,8 @@
 @click.argument('snapshot_id')
 @environment.pass_env
 def cli(env, volume_id, snapshot_id):
-    """"Refresh a dependent duplicate volume with a snapshot from its parent."""
+    """"Refresh a duplicate volume with a snapshot from its parent."""
     file_manager = SoftLayer.FileStorageManager(env.client)
-    resp = file_manager.refresh_dep_dupe(volume_id, snapshot_id)
+    resp = file_manager.refresh_dupe(volume_id, snapshot_id)
 
     click.echo(resp)

SoftLayer/fixtures/SoftLayer_Network_Storage.py

@@ -234,8 +234,8 @@
     'provisionedCount': 100
 }
 
-refreshDuplicate = {                            #remove Dependent from refreshDependentDuplicate
-     'DependentDuplicate': 1
+refreshDuplicate = {
+     'dependentDuplicate': 1
 }
 
 convertCloneDependentToIndependent = {

SoftLayer/managers/storage.py

@@ -415,13 +415,13 @@ def cancel_volume(self, volume_id, reason='No longer needed', immediate=False):
 
         return self.client.call('SoftLayer_Billing_Item', 'cancelItem', immediate, True, reason, id=billing_item_id)
 
-    def refresh_dupe(self, volume_id, snapshot_id):                                                  #remove dep
+    def refresh_dupe(self, volume_id, snapshot_id):
         """"Refresh a duplicate volume with a snapshot from its parent.
 
         :param integer volume_id: The id of the volume
         :param integer snapshot_id: The id of the snapshot
         """
-        return self.client.call('Network_Storage', 'refreshDuplicate', snapshot_id, id=volume_id)   #remove Dependent
+        return self.client.call('Network_Storage', 'refreshDuplicate', snapshot_id, id=volume_id)
 
 
 

tests/CLI/modules/block_tests.py

@@ -717,7 +717,7 @@ def test_volume_limit(self, list_mock):
         result = self.run_command(['block', 'volume-limits'])
         self.assert_no_fail(result)
 
-    def test_dupe_refresh(self):                                            #remove _dep in test_dep_dupe_refresh
+    def test_dupe_refresh(self):
         result = self.run_command(['block', 'volume-refresh', '102', '103'])
 
         self.assert_no_fail(result)

tests/CLI/modules/file_tests.py

@@ -696,7 +696,7 @@ def test_volume_limit(self, list_mock):
         result = self.run_command(['file', 'volume-limits'])
         self.assert_no_fail(result)
 
-    def test_dep_dupe_refresh(self):
+    def test_dupe_refresh(self):
         result = self.run_command(['file', 'volume-refresh', '102', '103'])
 
         self.assert_no_fail(result)

tests/managers/block_tests.py

@@ -1043,13 +1043,13 @@ def test_get_ids_from_username_empty(self):
         self.assert_called_with('SoftLayer_Account', 'getIscsiNetworkStorage')
         self.assertEqual([], result)
 
-    def test_refresh_block_dupe(self):                                              #remove dep in block_depdupe
-        result = self.block.refresh_dupe(123, snapshot_id=321)                      #remove dep in refresh_dep_dupe
-        self.assertEqual(SoftLayer_Network_Storage.refreshDuplicate, result)     #remove Dependent in refreshDependentDuplicate
+    def test_refresh_block_dupe(self):
+        result = self.block.refresh_dupe(123, snapshot_id=321)
+        self.assertEqual(SoftLayer_Network_Storage.refreshDuplicate, result)
 
         self.assert_called_with(
             'SoftLayer_Network_Storage',
-            'refreshDuplicate',                                #remove Dependent in refreshDependentDuplicate
+            'refreshDuplicate',
             identifier=123
         )
 

tests/managers/file_tests.py

@@ -892,13 +892,13 @@ def test_get_ids_from_username_empty(self):
         self.assert_called_with('SoftLayer_Account', 'getNasNetworkStorage')
         self.assertEqual([], result)
 
-    def test_refresh_file_depdupe(self):
-        result = self.file.refresh_dep_dupe(123, snapshot_id=321)
-        self.assertEqual(SoftLayer_Network_Storage.refreshDependentDuplicate, result)
+    def test_refresh_file_dupe(self):
+        result = self.file.refresh_dupe(123, snapshot_id=321)
+        self.assertEqual(SoftLayer_Network_Storage.refreshDuplicate, result)
 
         self.assert_called_with(
             'SoftLayer_Network_Storage',
-            'refreshDependentDuplicate',
+            'refreshDuplicate',
             identifier=123
         )