Review the change

Author: username1901

SoftLayer/CLI/block/refresh.py

@@ -1,4 +1,4 @@
-"""Refresh a dependent duplicate volume with a snapshot from its parent."""
+"""Refresh a duplicate volume with a snapshot from its parent."""
 # :license: MIT, see LICENSE for more details.
 
 import click
@@ -11,8 +11,9 @@
 @click.argument('snapshot_id')
 @environment.pass_env
 def cli(env, volume_id, snapshot_id):
-    """"Refresh a dependent duplicate volume with a snapshot from its parent."""
+    """"Refresh a duplicate volume with a snapshot from its parent."""
     block_manager = SoftLayer.BlockStorageManager(env.client)
-    resp = block_manager.refresh_dep_dupe(volume_id, snapshot_id)
+    resp = block_manager.refresh_dupe(volume_id, snapshot_id)               #remove dep_ in refresh_dep_dupe
 
     click.echo(resp)
+

SoftLayer/fixtures/SoftLayer_Network_Storage.py

@@ -234,8 +234,8 @@
     'provisionedCount': 100
 }
 
-refreshDependentDuplicate = {
-    'dependentDuplicate': 1
+refreshDuplicate = {                            #remove Dependent from refreshDependentDuplicate
+     'DependentDuplicate': 1
 }
 
 convertCloneDependentToIndependent = {

SoftLayer/managers/storage.py

@@ -415,13 +415,15 @@ def cancel_volume(self, volume_id, reason='No longer needed', immediate=False):
 
         return self.client.call('SoftLayer_Billing_Item', 'cancelItem', immediate, True, reason, id=billing_item_id)
 
-    def refresh_dep_dupe(self, volume_id, snapshot_id):
-        """"Refresh a dependent duplicate volume with a snapshot from its parent.
+    def refresh_dupe(self, volume_id, snapshot_id):                                                  #remove dep
+        """"Refresh a duplicate volume with a snapshot from its parent.
 
         :param integer volume_id: The id of the volume
         :param integer snapshot_id: The id of the snapshot
         """
-        return self.client.call('Network_Storage', 'refreshDependentDuplicate', snapshot_id, id=volume_id)
+        return self.client.call('Network_Storage', 'refreshDuplicate', snapshot_id, id=volume_id)   #remove Dependent
+
+
 
     def convert_dep_dupe(self, volume_id):
         """Convert a dependent duplicate volume to an independent volume.

tests/CLI/modules/block_tests.py

@@ -717,7 +717,7 @@ def test_volume_limit(self, list_mock):
         result = self.run_command(['block', 'volume-limits'])
         self.assert_no_fail(result)
 
-    def test_dep_dupe_refresh(self):
+    def test_dupe_refresh(self):                                            #remove _dep in test_dep_dupe_refresh
         result = self.run_command(['block', 'volume-refresh', '102', '103'])
 
         self.assert_no_fail(result)

tests/managers/block_tests.py

@@ -1043,13 +1043,13 @@ def test_get_ids_from_username_empty(self):
         self.assert_called_with('SoftLayer_Account', 'getIscsiNetworkStorage')
         self.assertEqual([], result)
 
-    def test_refresh_block_depdupe(self):
-        result = self.block.refresh_dep_dupe(123, snapshot_id=321)
-        self.assertEqual(SoftLayer_Network_Storage.refreshDependentDuplicate, result)
+    def test_refresh_block_dupe(self):                                              #remove dep in block_depdupe
+        result = self.block.refresh_dupe(123, snapshot_id=321)                      #remove dep in refresh_dep_dupe
+        self.assertEqual(SoftLayer_Network_Storage.refreshDuplicate, result)     #remove Dependent in refreshDependentDuplicate
 
         self.assert_called_with(
             'SoftLayer_Network_Storage',
-            'refreshDependentDuplicate',
+            'refreshDuplicate',                                #remove Dependent in refreshDependentDuplicate
             identifier=123
         )