[FIX] 내일 할 일을 동기화된 후 처음 삭제할 경우 삭제가 반영되지 않는 문제 해결

[rbgksqkr]

Issue Number

closed #318

As-Is

• 내일 할 일이 동기화된 상태에서 처음 삭제 시 삭제되지 않음

To-Be

• isTomorrowScheduleCreated가 true일 때만 응답 데이터로 받고, false일 때는 새로 불러온다.

Check List

• 테스트가 전부 통과되었나요?
• 모든 commit이 push 되었나요?
• merge할 branch를 확인했나요?
• Assignee를 지정했나요?
• Label을 지정했나요?

Test Screenshot

(Optional) Additional Description

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of todo deletion to ensure the todo list updates correctly, especially for "tomorrow" todos.

• Chores

  • Enhanced internal type safety for API responses related to deleting todos.

[coderabbitai]

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f5ee9f and 533cd0a.

📒 Files selected for processing (2)

• frontend/src/api/todo.ts (2 hunks)
• frontend/src/hooks/todo/useDeleteTodoMutation.ts (1 hunks)

🔇 Additional comments (4)

frontend/src/api/todo.ts (2)

75-83: Well-designed discriminated union type for conditional response handling.

The DeleteTodoResponse type effectively uses a discriminated union pattern to handle the two different response scenarios. This provides excellent type safety and aligns perfectly with the conditional logic needed to fix the synchronization issue.

---

164-164: Excellent type annotation for enhanced type safety.

The addition of the DeleteTodoResponse generic type parameter ensures proper typing for the delete operation's response, enabling compile-time type checking and better IDE support.

frontend/src/hooks/todo/useDeleteTodoMutation.ts (2)

4-6: Appropriate imports for the enhanced functionality.

The added imports for TODO_TYPE and Todo type are necessary for the conditional cache update logic and maintain consistency with the existing import structure.

---

14-19: Excellent fix for the synchronization issue.

The conditional logic correctly addresses the core problem described in the PR. By directly updating the cache with the returned data when isTomorrowScheduleCreated is true for TOMORROW todos, this should resolve the issue where the first deletion after synchronization wasn't reflected properly.

The fallback to cache invalidation maintains backward compatibility for other scenarios.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/#318

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.