Remove obsolete cmd2 console implementation#84
Closed
sodejm wants to merge 0 commit into
Closed
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
sodejm
force-pushed
the
codex/remove-obsolete-cmd2-console-implementation
branch
from
July 22, 2026 01:42
46be10c to
bd2fbc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cmd2-based interactive console and adapters and preserve the default prompt-toolkit/Rich REPL and one-shot CLI paths.cmd2and simplify module loading so command execution is handled by the transport-neutral CLI dispatcher.Description
src/ancestryllm/console/app.pycmd2implementation with a small compatibility facadeAncestryConsolethat subclasses the existingReplApplicationfromconsole.shelland preservescmdloop()behavior.cmd2adapter modules and helpers undersrc/ancestryllm/console/:command_sets.py,gedcom.py,rootsmagic.py,people.py,prompts.py,ocr.py,secrets.py, andproviders.py.BUILTIN_MODULESentries insrc/ancestryllm/core/modules.pyto reference the one-shot dispatcher (ancestryllm.cli:run_tokens) and changedModuleRegistry.load()to return descriptors without importing the old console adapters.cmd2frompyproject.tomldependencies so runtime no longer requires the obsolete console package.Testing
python -m pip install -e .completed successfully in the test environment.python -m compilealland compilation succeeded without syntax errors.tests/modular/test_repl_shell.py,tests/modular/test_repl_router.py, andtests/modular/test_repl_history.py, and they passed (interactive REPL and router behavior preserved).tests/modular/test_command_specs.pystill contains a legacy expectation asserting thatModuleRegistry.load()imports the old console adapters, which no longer holds after this refactor; that test must be updated to match the new behavior (current run shows it failing for that legacy expectation).Codex Task