Build and pass tags as options to logger #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
HolyWalley
force-pushed
the
support-tagged-logging
branch
from
0812102 to
80bedea
Compare
HolyWalley
commented
Sep 4, 2025
HolyWalley
commented
Sep 8, 2025
| gem "bake-test-external" | ||
|
|
||
| gem "sqlite3", "~> 1.4" | ||
| gem "sqlite3", ">= 1.4" |
Author
There was a problem hiding this comment.
this way it works with rails 8.0+
Member
|
Apologies for the late review. I've just released v0.5 which fixes compatibility with Rails thanks to @jasl Do you mind rebasing this? |
HolyWalley
force-pushed
the
support-tagged-logging
branch
from
1932457 to
c6ab122
Compare
Author
|
Hey @ioquatix |
Author
|
I'll check and fix red CI a bit later, sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This is one of 2 changes needed to support the use of
Rails.logger.tagged(another part)This only works with hash type tags, e.g.
Rails.logger.tagged({ request_id: 137 })Types of Changes
Contribution