fix: tag and release #57
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
james-snyk
force-pushed
the
feat/tag-and-release
branch
from
374d995 to
33ecc8b
Compare
james-snyk
force-pushed
the
feat/tag-and-release
branch
from
33ecc8b to
a452fe1
Compare
|
✅ Valid — 🟢 PATCH |
| else | ||
| echo "Warning: No recognized commit type, defaulting to PATCH" | ||
| BUMP_TYPE="patch" | ||
| PATCH=$((PATCH + 1)) |
There was a problem hiding this comment.
Why not default to none; at least it makes it explicit when a PR requests a version bump?
Or if the repo requires conventional commits you could even reject the PR in this default branch.
| echo "PR title: $PR_TITLE" | ||
|
|
||
| # Determine version bump based on PR title | ||
| if [[ "$PR_TITLE" =~ ^\[major\]|^major: ]]; then |
There was a problem hiding this comment.
conventional commits also define BREAKING CHANGE and just appending a ! to whatever the type of change, eg fix(api)!: ..., which would be nice to support here.
There was a problem hiding this comment.
Indeed. although the ! doesn't work for most of our repos.
| - checkout | ||
| - add_ssh_keys: | ||
| fingerprints: | ||
| - "SHA256:w5lYpE8DMWxUdasN8yMbbFdiz6s50PPBJMkV0a1iyZ8" |
There was a problem hiding this comment.
Yeah, looks secrety. This is something that should probably be read from elsewhere
There was a problem hiding this comment.
its the sha of the deploy key id in circleci. it tells circleci what key to use when tagging the repo. The id is public so its safe to have this in the config.
What this does
tag the repo after merging.
The version is bumped based on the prefix in the PR title.
fix bumps the patch version, feat bumps the minor version and major bumps the major version.