Skip to content

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title add more logging SNOW-925245: [snowflake-connector-nodejs] please consider enhancing chunk download logging for supportability Aug 5, 2025
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review August 5, 2025 21:26
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner August 5, 2025 21:26
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.62%. Comparing base (06ebe2c) to head (f45e9b1).

Files with missing lines Patch % Lines
lib/file_transfer_agent/remote_storage_util.js 64.70% 6 Missing ⚠️
lib/file_transfer_agent/azure_util.js 50.00% 2 Missing ⚠️
lib/file_transfer_agent/gcs_util.js 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
+ Coverage   89.59%   89.62%   +0.02%     
==========================================
  Files          83       83              
  Lines        7681     7710      +29     
  Branches       61       61              
==========================================
+ Hits         6882     6910      +28     
- Misses        789      790       +1     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@sfc-gh-dszmolka sfc-gh-dszmolka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants